Add one char delay before switching TRX control, fixed warnings #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added one char to TRX control delay, when switching back to read. This prevents hazardous states on CPUs, where is the UART "slow" and switching the GPIO pin can be faster, then finishing sending of the data (e.g. Rockchip RK3328).
Modbus specs says, that delay between two frames must be at least t3.5 chars for bauds <= 19200 and 1.75ms for higher bauds, so this modifications should be safe.
Tested on RockPi E and BeagleBone black.
Fixed also some compiler warnings and non working -r argument.