Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtual Repeater doesn't always resize correctly in Tree panel #713

Closed
Charence opened this issue Feb 6, 2018 · 4 comments
Closed

Virtual Repeater doesn't always resize correctly in Tree panel #713

Charence opened this issue Feb 6, 2018 · 4 comments

Comments

@Charence
Copy link
Contributor

Charence commented Feb 6, 2018

screenshot 2018-02-06 10 26 06
screenshot 2018-02-06 10 26 24
screenshot 2018-02-06 10 26 34
screenshot 2018-02-06 10 26 52
screenshot 2018-02-06 10 27 19
screenshot 2018-02-06 10 27 32

@Charence Charence added the bug label Feb 6, 2018
@JamesLMilner
Copy link
Contributor

This is very hard to fix. We use AngularJS Material which is no longer supported, and getting the virtual scroll box to resize effectively is quite problematic.

See angular/material#4314

I haven't tried this, but not sure if it's even the right solution: https://stackoverflow.com/questions/34912151/is-there-a-way-to-refresh-virtual-repeat-container

@JamesLMilner
Copy link
Contributor

@Charence can you also specify reproducable behaviour for this bug?

@JamesLMilner JamesLMilner changed the title Tree UI bug Virtual Repeater doesn't always resize correctly in Tree panel Feb 6, 2018
@Charence
Copy link
Contributor Author

Charence commented Feb 6, 2018

@JamesMilnerUK

Case 1:

Case 2:

Case 3:

It seems like the positioning of the virtual repeater is somehow linked to the panel above it. In the above screenshots, you can see that the virtual repeater and its elements extends beyond the top of the Tree panel.

@JamesLMilner
Copy link
Contributor

@Charence think I have a fix for this but also I'm blocked by #716. Can you take a look when you've got a second?

JamesLMilner added a commit that referenced this issue Feb 7, 2018
JamesLMilner added a commit that referenced this issue Feb 7, 2018
Charence added a commit that referenced this issue Feb 7, 2018
ISSUE #713 - use window resize event to force tree resize
@JamesLMilner JamesLMilner modified the milestones: v2.7.1, v2.7.3 Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants