Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI - Update to Lizmap server plugin and its version #3132

Merged
merged 1 commit into from
Jul 29, 2022

Conversation

Gustry
Copy link
Member

@Gustry Gustry commented Jul 27, 2022

Linked to #2972 @mdouchin

It would be nice to hardcode as well the QGIS version, so we don't need to translate in Transifex everytime we change the QGIS version (and Lizmap server plugin version as well)

@Gustry
Copy link
Member Author

Gustry commented Jul 27, 2022

I didn't find in a XML jform file how to dynamically format a string.

My PHP are quite rusty, trying to manage how to format strings in a template.

@Gustry Gustry requested review from laurentj and mdouchin July 27, 2022 19:15
Copy link
Collaborator

@mdouchin mdouchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@Gustry
Copy link
Member Author

Gustry commented Jul 29, 2022

I finally found how to make jform with a dynamic help string.

@laurentj and @mdouchin Where would be the best place to make $qgisMinimumVersionRequired and $lizmapPluginMinimumVersionRequired global ? (for these two files and later for #2972)

@mdouchin
Copy link
Collaborator

I finally found how to make jform with a dynamic help string.

@laurentj and @mdouchin Where would be the best place to make $qgisMinimumVersionRequired and $lizmapPluginMinimumVersionRequired global ? (for these two files and later for #2972)

I would say we could add them in the mainconfig.ini.php, or better in lizmapConfig.ini.php ? Or we could create a new file lizmapQgisServerVersionTable.ini.php with these variables to facilitate it update when releasing a new version (I prefer this dedicated file)

@Gustry
Copy link
Member Author

Gustry commented Jul 29, 2022

Ok, let's try in a next PR, related to #2972 . Merging in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants