Do not decode internal data param without address (#174)

3loop · Dec 10, 2024 · da3a060 · da3a060
1 parent ade1be3
commit da3a060
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/.changeset/stale-bottles-rule.md b/.changeset/stale-bottles-rule.md
@@ -0,0 +1,5 @@
+---
+'@3loop/transaction-decoder': patch
+---
+
+Do not decode internal calldata param without knowing the address
diff --git a/packages/transaction-decoder/src/decoding/calldata-decode.ts b/packages/transaction-decoder/src/decoding/calldata-decode.ts
@@ -52,11 +52,11 @@ const decodeBytesRecursively = (
       }
     }
 
-    if (isCallDataNode) {
+    if (isCallDataNode && address) {
       const decoded = yield* decodeMethod({
         data: node.value as Hex,
-        chainID: address ? chainID : 0,
-        contractAddress: address ?? '',
+        chainID,
+        contractAddress: address,
       }).pipe(Effect.orElseSucceed(() => null))
 
       return decoded