Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCC startup (istep 21.1) #100

Merged
merged 66 commits into from
Oct 20, 2021
Merged

OCC startup (istep 21.1) #100

merged 66 commits into from
Oct 20, 2021

Conversation

SergiiDmytruk
Copy link
Member

Includes #89.

krystian-hebel
krystian-hebel requested changes Oct 11, 2021
View reviewed changes
src/include/cpu/power/occ.h Outdated Show resolved Hide resolved
src/include/cpu/power/occ.h Outdated Show resolved Hide resolved
src/include/cpu/power/occ.h Outdated Show resolved Hide resolved
src/include/cpu/power/occ.h Outdated Show resolved Hide resolved
src/soc/ibm/power9/Makefile.inc Outdated Show resolved Hide resolved
src/soc/ibm/power9/occ.c Outdated Show resolved Hide resolved
src/soc/ibm/power9/occ.c Outdated Show resolved Hide resolved
src/soc/ibm/power9/homer.c Outdated Show resolved Hide resolved
src/soc/ibm/power9/homer.c Outdated Show resolved Hide resolved
src/soc/ibm/power9/homer.c Outdated Show resolved Hide resolved
krystian-hebel
krystian-hebel requested changes Oct 12, 2021
View reviewed changes
src/soc/ibm/power9/homer.c Outdated Show resolved Hide resolved
src/soc/ibm/power9/homer.c Outdated Show resolved Hide resolved
src/soc/ibm/power9/homer.c Outdated
write_scom(PU_GPE2_PPE_XIXCR, PPC_PLACE(RESUME, 1, 3));

/* Does this need to be such a long time? */
wait_ms(20*TIMEOUT_COUNT,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
wait_ms(20*TIMEOUT_COUNT,
wait_ms(PGPE_POLLTIME_MS * TIMEOUT_COUNT,

I wonder if we should add a version of wait_ms() to coreboot that checks condition periodically instead of using busy loop. For memory training busy reading significantly slowed down the training. The issue is that we can't use delay() in ramstage, at least not in the same form. Still, this is not part of this task, I'm just thinking out loud 🙂

src/soc/ibm/power9/homer.c Outdated Show resolved Hide resolved
src/soc/ibm/power9/homer.c Outdated Show resolved Hide resolved
src/soc/ibm/power9/homer.c Outdated Show resolved Hide resolved
src/soc/ibm/power9/homer.c Outdated Show resolved Hide resolved
src/soc/ibm/power9/homer.c Outdated Show resolved Hide resolved
src/soc/ibm/power9/occ.c Outdated Show resolved Hide resolved
src/soc/ibm/power9/occ.c Outdated Show resolved Hide resolved
krystian-hebel
krystian-hebel requested changes Oct 19, 2021
View reviewed changes
Copy link
Member

@krystian-hebel krystian-hebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change, otherwise LGTM

src/soc/ibm/power9/fir.c Outdated Show resolved Hide resolved
Igor Bagnucki and others added 24 commits October 19, 2021 19:36
@SergiiDmytruk
Add OCC operations
e166d04 
Signed-off-by: Igor Bagnucki <igor.bagnucki@3mdeb.com>
@SergiiDmytruk
Beginning of istep 21.1
fbd21d6 
Change-Id: Ia342e6befc92c52dcced360dbc5c658ddf31d6b8
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Continue with start_pm_complex()
a292066 
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Finish with setup_memory_boot()
6d0bb7a 
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Implement special_wakeup_all(enable=false)
11ed04b 
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
pm_corequad_init()
08990d1 
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Implement pstate_gpe_init()
e82f559 
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Implement pm_pba_init()
5556398 
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Initialize MCS bits in configuration vector
dcf3260 
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Implement wait_for_occ_checkpoint()
6c99246 
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Implement poll_occ()
6c498cc 
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
The bulk of sending commands to OCC
8a758f0 
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Finish implementing communication with OCC
ec9c079 
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Implement switching OCC to active state
8bb2627 
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Initialize user power limit (no limit)
efeab6c 
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Start implementing send_occ_config_data()
2ba98cf 
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Add PCAP config data
429affe 
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Do not auto-start Pstate GPE protocol
c794f08 
Hostboot doesn't seem to do it and it times out anyway.

Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Fix SCOM addrs in pba_slave_setup_runtime_phase()
d1c99d8 
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Fix bugs on constructing bootcode for OCC
5ed5194 
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Simplify pba_slave_setup_runtime_phase()
242647d 
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Fix stack usage errors
4e2483f 
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Fix PPC_PLACE() macros in pb_pba_init()
9dff7d5 
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Simplify pm_pba_bar_config()
3343f06 
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Add informational messages
1d7d73f 
It takes some time to start OCC.

Change-Id: I1609349c673b4f0295e4e743add61f66a66aa6b1
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Formatting corrections for occ.h/occ.c
bd04816 
Change-Id: I56651886bc752ce9f17707ff0393abfdb65cb51d
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
A couple of corrections
27bb8b7 
Change-Id: I4ab8a73cb73ccd486f08713920e8c389adff22b7
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Remove makeStart405Instruction() and related
a547bf1 
Change-Id: I632fbad29216554ba44055ce803d912a4246da4c
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Extract ops.h
57c1d80 
Change-Id: Ia3d53035ac34e64cd5c224e1423526990f62df06
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Move some OCC-specific code from homer.c to occ.c
6b1e3ed 
Change-Id: Iebbba0ecaa235c37c70d182ec03022d852402971
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Update OP codes
5589346 
Change-Id: Idfe51a377fd01d945ba888f4cc613742f067a955
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Fixes for sending wakeups
953dd8b 
Change-Id: I5a011866c2453801a5e998fe87550b3e288f970d
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Don't set HOMER BAR second time
8dc0379 
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Remove extra delay in check_ocb_mode()
6f1f74b 
Change-Id: I53c1c46492d57032d02bf3fc514933e4f4f50597
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Move ppc_* functions from occ.c to ops.h
3eb1d82 
Change-Id: Ic6ebdd8e6fa2f8347f60d6a2435ce7c4ef1eb19d
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Simplify special_occ_wakeup_disable()
2d9b4b3 
Change-Id: I93427b99d18f3ca8b35c5cc9d0414a8d868f7f6d
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Comments and corrections for pm_pss_init()
85949d4 
Change-Id: I75a7bbf1474ffe556356f04e28d23bd47d14004f
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Remove duplicated pba slave setup
61ecb4c 
Change-Id: I8a634e023dd8cecfa771c68ebe5134c1d4acf04e
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Fix deadcode in write_occ_cmd()
f02ea98 
Change-Id: Ia13098cedf6e68889a4152dfb616710aebb488d1
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Various review corrections
3c6d38c 
Change-Id: Ia70f487001b965648ec779353149f2c62f996670
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Compute SCOM values using PPC_* macros
4cf184a 
Change-Id: I306de2b11cd98cc99c3262dc74dabcf8c22565d7
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Use correct PB freq in one more place
d579f61 
Change-Id: I212fec18384c81488b5f3de1631dda1df08248d0
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Initialize PBA slaves earlier (on PBA reset)
f9c2637 
Change-Id: Ia0e991efe26b8abf6f020cb10eb82f951674e25b
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Add pm_occ_fir_init()
5182aed 
Change-Id: I483b9ce660a7d840a52437f1de0428df2ea84706
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Add pm_pba_fir_init()
3bc8399 
Also fix a bug in pm_occ_fir_init() and move the two functions to a
separate file.

Change-Id: Idbbbe002ed673beaad18ccd144f193a290baf969
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Make SCOM writes match Hostboot
6ec1403 
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@SergiiDmytruk
Merge fir.c into occ.c
b1915fa 
Change-Id: I3e60bd4b2299691cb18df98c218514671eb3a440
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
@krystian-hebel
Copy link
Member

Let's wait for CI tests before merging.

@krystian-hebel krystian-hebel merged commit 112d666 into 3mdeb:talos_2_support_payload Oct 20, 2021
@SergiiDmytruk SergiiDmytruk deleted the istep_21_1 branch October 20, 2021 21:46
@SergiiDmytruk SergiiDmytruk mentioned this pull request Feb 4, 2022
Merged
@tlaurion tlaurion mentioned this pull request Jul 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krystian-hebel krystian-hebel krystian-hebel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SergiiDmytruk @krystian-hebel