Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Night Mode Toogle #147

Open
wants to merge 31 commits into
base: master
Choose a base branch
from
Open

Night Mode Toogle #147

wants to merge 31 commits into from

Conversation

CryptorClub
Copy link
Contributor

@CryptorClub CryptorClub commented Sep 23, 2018

Live version: https://greencoin.online - Toogle at top right corner

@knkrth
Copy link
Contributor

knkrth commented Sep 24, 2018

@CryptorClub I added search icon. Can you test it? Patch 5 Patch 6 Patch 7

@CryptorClub
Copy link
Contributor Author

@knkrth, it's strange for me, read about icon... Is search function works fine?

@knkrth
Copy link
Contributor

knkrth commented Sep 24, 2018

@CryptorClub I did not test it so that only I ask you to test it. Can you explain what's strange with the search icon?

@knkrth
Copy link
Contributor

knkrth commented Sep 24, 2018

@CryptorClub Check out the wallet section at https://altmarkets.cc search icon works fine.

@jonn4y
Copy link
Contributor

jonn4y commented Sep 24, 2018

yeah i changed the styling a little just to match the rest of my theme but otherwise works great, little issue when you have so many coins on the exchange as they dont all load at once it Async loads them as you scroll down so if the coins aren't loaded yet they wont come up in the search, i will try and find a resolution for this but so far seems a hit for my members.

@knkrth
Copy link
Contributor

knkrth commented Sep 25, 2018

@3s3s Why you don't merge this request? This UI seems to looks better. The market section is bigger & Coin, Price, Vol, Ch % is seems to looking good without the scroll bar at the bottom.

@3s3s
Copy link
Owner

3s3s commented Sep 25, 2018

@3s3s Why you don't merge this request? This UI seems to looks better. The market section is bigger & Coin, Price, Vol, Ch % is seems to looking good without the scroll bar at the bottom.

Hi. Please use this Pull Request Philosophy
Commits should be atomic and diffs should be easy to read.
Patch sets should always be focused. For example, a pull request could add a feature, fix a bug, or refactor code; but not a mixture. Please also avoid super pull requests which attempt to do too much, are overly large, or overly complex as this makes review difficult.

@knkrth
Copy link
Contributor

knkrth commented Sep 25, 2018

@3s3s Ok I get it. Do you have any plans on updating the UI with your own templates?

@CryptorClub
Copy link
Contributor Author

CryptorClub commented Sep 25, 2018

@3s3s Why you don't merge this request? This UI seems to looks better. The market section is bigger & Coin, Price, Vol, Ch % is seems to looking good without the scroll bar at the bottom.

Hi. Please use this Pull Request Philosophy
Commits should be atomic and diffs should be easy to read.
Patch sets should always be focused. For example, a pull request could add a feature, fix a bug, or refactor code; but not a mixture. Please also avoid super pull requests which attempt to do too much, are overly large, or overly complex as this makes review difficult.

Thanks. I'll be separately in future.

@ghost
Copy link

ghost commented Oct 1, 2018

This looks great!

I'd love to see an addition to have it change the logo to a new image as well. I.E. dark and light logo options!

@whiteyhat
Copy link

This branch has conflicts, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants