Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/Update grafana dashboards showing negative values #44

Merged
merged 4 commits into from
Oct 24, 2022

Conversation

slopezz
Copy link
Member

@slopezz slopezz commented Oct 21, 2022

  • A few dashboards whose specific metrics tends to be 0, are showing negative values because Ymin=null (which means is auto).

    • On some cases where values are very high, Ymin=null (auto) is good, because it adapts automatically to each value, making simpler to check the evolution:
      • Good having Ymin=null (auto)
        image
      • Instead of Ymin=0 (bad)
        image
    • However, on some case where metrics tend to be 0, having Ymin=null (auto) means showing negative values on the panel, which makes no sense:
      image
      • This PR fixes a few cases on memcached and postgres grafana dashboards where it is better to have Ymin=0
  • In addition, it simplifies the mysql database example used to show how the exporter can be deployed, because it stopped working after last time it was checked.

  • Alpha release v0.6.0-alpha.3 has been successfully tested in development cluster.

/kind bug
/priority important-soon
/assign

@3scale-robot 3scale-robot added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. labels Oct 21, 2022
@3scale-robot 3scale-robot added size/S Requires less than a day to complete the PR or the issue. and removed needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. labels Oct 21, 2022
@3scale-robot 3scale-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2022
@3scale-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8e32c1467f018ce298ddcc6a61f824c2e749f61e

Copy link
Contributor

@raelga raelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@slopezz
Copy link
Member Author

slopezz commented Oct 24, 2022

/approve

@3scale-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slopezz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@3scale-robot 3scale-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2022
@3scale-robot 3scale-robot merged commit d1acfb4 into main Oct 24, 2022
@3scale-robot 3scale-robot deleted the feat/update-grafana-dashboards branch October 24, 2022 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. size/S Requires less than a day to complete the PR or the issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants