-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/Update grafana dashboards showing negative values #44
Conversation
LGTM label has been added. Git tree hash: 8e32c1467f018ce298ddcc6a61f824c2e749f61e
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: slopezz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
A few dashboards whose specific metrics tends to be 0, are showing negative values because
Ymin=null
(which means isauto
).Ymin=null (auto)
is good, because it adapts automatically to each value, making simpler to check the evolution:Ymin=null (auto)
Ymin=0
(bad)Ymin=null (auto)
means showing negative values on the panel, which makes no sense:Ymin=0
In addition, it simplifies the mysql database example used to show how the exporter can be deployed, because it stopped working after last time it was checked.
Alpha release
v0.6.0-alpha.3
has been successfully tested in development cluster./kind bug
/priority important-soon
/assign