Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/Add manticore prometheus-exporter and stable release v0.8.0 #51

Merged
merged 10 commits into from
Feb 22, 2024

Conversation

slopezz
Copy link
Member

@slopezz slopezz commented Feb 22, 2024

3scale API Management product is transitioning from using sphinxsearch to manticoresearch

Sphinx prometheus-exporter seems to not be able to monitor a manticore instance, so this PR adds the official manticoresearch prometheus exporter to prometheus-exporter-operator

Aside from adding the exporter:

  • I created a grafana dashboard from scratch by looking at the metrics, as a kind of start point.
    Screenshot from 2024-02-21 12-32-11

  • I miss one important metric reporting the status of the manticore instance, the usual up metric provided by any exporter, on that case should be manticore_up (0 -> Down and 1 -> UP), that's why in the example alert I added for ManticoreDown, I used an absent promql query function absent(manticore_uptime_seconds) == 1

/kind feature
/kind release
/priority important-soon
/assign

@3scale-robot 3scale-robot added kind/feature Categorizes issue or PR as related to a new feature. kind/release Categorizes issue or PR as related to a new release. labels Feb 22, 2024
@3scale-robot 3scale-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. size/XL Requires about a week to complete the PR or the issue. and removed needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. labels Feb 22, 2024
@3scale-robot 3scale-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2024
@3scale-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6d319673d2f0aaab6c4057f4baf449986910b3d9

@slopezz
Copy link
Member Author

slopezz commented Feb 22, 2024

/approve

@3scale-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slopezz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@3scale-robot 3scale-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2024
@3scale-robot 3scale-robot merged commit 1b5a9fe into main Feb 22, 2024
2 checks passed
@3scale-robot 3scale-robot deleted the feat/manticore-exporter branch February 22, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. kind/release Categorizes issue or PR as related to a new release. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. size/XL Requires about a week to complete the PR or the issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants