-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/Add manticore prometheus-exporter and stable release v0.8.0 #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3scale-robot
added
kind/feature
Categorizes issue or PR as related to a new feature.
kind/release
Categorizes issue or PR as related to a new release.
labels
Feb 22, 2024
3scale-robot
added
priority/important-soon
Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint.
needs-size
Indicates a PR or issue lacks a `size/foo` label and requires one.
size/XL
Requires about a week to complete the PR or the issue.
and removed
needs-size
Indicates a PR or issue lacks a `size/foo` label and requires one.
labels
Feb 22, 2024
slopezz
force-pushed
the
feat/manticore-exporter
branch
from
February 22, 2024 10:46
972abfc
to
3e97191
Compare
roivaz
approved these changes
Feb 22, 2024
LGTM label has been added. Git tree hash: 6d319673d2f0aaab6c4057f4baf449986910b3d9
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: slopezz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3scale-robot
added
the
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
label
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
kind/feature
Categorizes issue or PR as related to a new feature.
kind/release
Categorizes issue or PR as related to a new release.
lgtm
Indicates that a PR is ready to be merged.
priority/important-soon
Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint.
size/XL
Requires about a week to complete the PR or the issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3scale API Management product is transitioning from using sphinxsearch to manticoresearch
Sphinx prometheus-exporter seems to not be able to monitor a manticore instance, so this PR adds the official manticoresearch prometheus exporter to prometheus-exporter-operator
6.2.13.0
from DockerHub https://hub.docker.com/r/manticoresearch/prometheus-exporter/tagsAside from adding the exporter:
I created a grafana dashboard from scratch by looking at the metrics, as a kind of start point.
I miss one important metric reporting the status of the manticore instance, the usual
up
metric provided by any exporter, on that case should bemanticore_up
(0 -> Down and 1 -> UP), that's why in the example alert I added forManticoreDown
, I used anabsent
promql query functionabsent(manticore_uptime_seconds) == 1
/kind feature
/kind release
/priority important-soon
/assign