Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/cross-namespace-dashboard-import #52

Merged
merged 2 commits into from
May 9, 2024

Conversation

roivaz
Copy link
Member

@roivaz roivaz commented May 9, 2024

Cross namespace import does not work when using v1beta1 grafana-operator API, as it does for v1alpha1. This PR fixes it.

/kind bug
/priority important-soon
/assign

@3scale-robot 3scale-robot added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. labels May 9, 2024
@3scale-robot 3scale-robot added needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. size/S Requires less than a day to complete the PR or the issue. and removed needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. labels May 9, 2024
@raelga
Copy link
Contributor

raelga commented May 9, 2024

/lgtm

@3scale-robot 3scale-robot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2024
@3scale-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a4207634d126c7bcb8b0767a30f67c134a1e0540

@roivaz
Copy link
Member Author

roivaz commented May 9, 2024

/approve

@3scale-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roivaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@3scale-robot 3scale-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2024
@3scale-robot 3scale-robot merged commit 9f732cf into main May 9, 2024
2 checks passed
@3scale-robot 3scale-robot deleted the fix/cross-namespace-dashboard-import branch May 9, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. size/S Requires less than a day to complete the PR or the issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants