Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Timeout waiting for process kube apisever to stop #206

Merged
merged 2 commits into from
Jun 20, 2022
Merged

fix: Timeout waiting for process kube apisever to stop #206

merged 2 commits into from
Jun 20, 2022

Conversation

raelga
Copy link
Contributor

@raelga raelga commented Jun 20, 2022

pro-saas and stg-saas are running k8s 1.21, so the saas-operator test environment should be updated accordingly.

v1.21 enables the GracefullShutdown feature for the API service and that requires some changes to the teardown step as described in kubernetes-sigs/controller-runtime#1571 (comment) and kubernetes-sigs/controller-runtime#1571.

/kind maintenance
/kind feature
/priority important-soon
/assign

@3scale-robot 3scale-robot added kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. labels Jun 20, 2022
@3scale-robot
Copy link
Contributor

@raelga: The label(s) kind/maintenance cannot be applied, because the repository doesn't have them.

In response to this:

pro-saas and stg-saas are running k8s 1.21, so the saas-operator test environment should be updated accordingly.

v1.21 enables the GracefullShutdown feature for the API service and that requires some changes to the teardown step as described in kubernetes-sigs/controller-runtime#1571 (comment) and kubernetes-sigs/controller-runtime#1571.

/kind maintenance
/kind feature
/priority important-soon
/assign

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@3scale-robot 3scale-robot added needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. size/S Requires less than a day to complete the PR or the issue. and removed needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. labels Jun 20, 2022
@raelga raelga mentioned this pull request Jun 20, 2022
Merged
@slopezz
Copy link
Member

slopezz commented Jun 20, 2022

/lgtm

@3scale-robot 3scale-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 20, 2022
@3scale-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: da2ecd8469e8d95706e3d61012c0d058f425420b

@raelga
Copy link
Contributor Author

raelga commented Jun 20, 2022

/approve

@3scale-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: raelga

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@3scale-robot 3scale-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 20, 2022
@3scale-robot 3scale-robot merged commit bed95e3 into main Jun 20, 2022
@3scale-robot 3scale-robot deleted the fix/timeout-waiting-for-process-kube-apisever-to-stop branch June 20, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roivaz roivaz Awaiting requested review from roivaz

@slopezz slopezz Awaiting requested review from slopezz

Assignees

@raelga raelga

@slopezz slopezz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. size/S Requires less than a day to complete the PR or the issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raelga @3scale-robot @slopezz