Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing Error 'resolv.conf' file #630

Closed
2 tasks done
maneta opened this issue Feb 27, 2018 · 1 comment
Closed
2 tasks done

Parsing Error 'resolv.conf' file #630

maneta opened this issue Feb 27, 2018 · 1 comment

Comments

@maneta
Copy link

maneta commented Feb 27, 2018

From expanding the tests on the PR #618 we have found several issues with parse_nameservers function in the gateway/src/resty/resolver.lua file.

Identified Problems
  1. The bellow expression will do not catch the case where server == resolver because the function to.string of the meta table resolver is concatenating "serverName_ip".."ServerNamePort"
    if server and server ~= resolver then
      insert(nameservers, nameserver.new(server))
    end
  1. The parsing of search local.domain #foobar brakes the regex

Those are the identified cases I found that brakes the resolver. Maybe should extend a bit the test cases.

To Do:
  • correct server == resolver case
  • correct parsing search local.domain #foobar
@mikz
Copy link
Contributor

mikz commented Jun 11, 2018

Fixed by #618, #635, #636

@mikz mikz closed this as completed Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants