Avoid nameserver duplication #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikz
reviewed
Mar 1, 2018
spec/resty/resolver_spec.lua
Outdated
| @@ -179,11 +179,12 @@ nameserver 127.0.0.1 | |||
| end) | |||
|
|
|||
| it('returns nameserver touples', function() | |||
There was a problem hiding this comment.
I think this deserves a new test. Because it basically changes it so we don't have a test for the order of returned nameservers from a normal file.
There was a problem hiding this comment.
I agree. Also, I think that we have similar problems with other tests. For example, this test is checking that commented lines are ignored, but there isn't an it clause explaining that or an explicit assertion.
mikz
reviewed
Mar 1, 2018
| --- user_files | ||
| >>> resolv.conf | ||
| nameserver 127.0.1.1 | ||
| nameserver 1.2.3.4 |
There was a problem hiding this comment.
Missing newline at the end of the file. Would be good to set-up your editor to always keep a new-line at the EOF.
mikz
approved these changes
Mar 1, 2018
davidor
reviewed
Mar 1, 2018
| @@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/). | |||
|
|
|||
| - Error loading policy chain configuration JSON with null value [PR #626](https://github.com/3scale/apicast/pull/626) | |||
| - Splitted `resolv.conf` in lines,to avoid commented lines [PR #618](https://github.com/3scale/apicast/pull/618) | |||
| - Avoid `nameserver` repetion from `RESOLVER` variable and `resolv.conf` file [PR #636](https://github.com/3scale/apicast/pull/636) | |||
davidor
reviewed
Mar 1, 2018
| assert.same({ '127.0.0.1', 53 }, nameservers[2]) | ||
| end) | ||
|
|
||
| it('do not replicates nameservers from resolver env var', function() |
|
👍 Thanks for your contribution @maneta |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
correct
server == resolvercase in #630