Mapping Rule: Use unescaped rule #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eloycoto
changed the title
mayorova
requested changes
Oct 3, 2019
gateway/src/apicast/proxy.lua
Outdated
| @@ -242,7 +242,7 @@ function _M:rewrite(service, context) | |||
| return errors.no_credentials(service) | |||
| end | |||
|
|
|||
| local usage, matched_rules = service:get_usage(ngx.req.get_method(), ngx.var.uri) | |||
| local usage, matched_rules = service:get_usage(ngx.req.get_method(), ngx.var.request_uri) | |||
There was a problem hiding this comment.
AFAIK $request_uri includes arguments and $uri doesn't.
The docs are explicit about $request_uri, but not $uri.
So, I think the query parameters should be stripped out from ngx.var.request_uri first (e.g. ?q=query).
There was a problem hiding this comment.
WIP PR, ngx.var.set_uri() modified ngx.var.uri and no request.uri, so it's not valid at all ;-)
eloycoto
force-pushed
the
REQUEST_URI_ISSES
branch
16 times, most recently
from
74211bd
to
259000f
Compare
eloycoto
changed the title
eloycoto
force-pushed
the
REQUEST_URI_ISSES
branch
4 times, most recently
from
18e82bd
to
2edffe0
Compare
davidor
reviewed
Oct 15, 2019
ngx.escape functions are not valid to encode the URI, due to it also encodes characters like: /, ?, etc.. This commit uses the ngx_string.h ngx_escape function that it's what NGINX uses internally and provide the right setup for this use case. Signed-off-by: Eloy Coto <eloy.coto@gmail.com>
Signed-off-by: Eloy Coto <eloy.coto@gmail.com>
eloycoto
force-pushed
the
REQUEST_URI_ISSES
branch
from
2edffe0
to
181f31a
Compare
davidor
approved these changes
Oct 15, 2019
mayorova
approved these changes
Oct 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit address the issues with the mapping rules that normalizes
the URL and mapping rules are not matching correctly.
Fix #1002
Fix THREESCALE-3468
Signed-off-by: Eloy Coto eloy.coto@gmail.com