Upstream: return error if the value given is cjson.null #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On read JSON config the null values are not consider nil. Due to the latest changes on porta related to the null api_backend, APIcast will raise an exception and things started to fail. Related-to: 3scale/porta#1385 Fix: THREESCALE-3869 Signed-off-by: Eloy Coto <eloy.coto@gmail.com>
eloycoto
force-pushed
the
THREESCALE-3869
branch
from
36d6a33 to
925c8e4
Compare
davidor
approved these changes
Nov 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On read JSON config the null values are not consider nil. Due to the
latest changes on porta related to the null api_backend, APIcast will
raise an exception and things started to fail.
Related-to: 3scale/porta#1385
Fix: THREESCALE-3869
Signed-off-by: Eloy Coto eloy.coto@gmail.com