Mapping rules: Avoid issues with double slash. #1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the work make in APIAP, the double slash can happen quite easily, as described in THREESCALE-3950. With this commit, when a new mapping_rule is defined, double slash will be simplified to one to be able to match with ngx.var.uri. FIX THREESCALE-3950 Signed-off-by: Eloy Coto <eloy.coto@gmail.com>
eloycoto
force-pushed
the
THREESCALE-3950
branch
from
a903bae
to
c0a23dc
Compare
davidor
reviewed
Jan 23, 2020
| @@ -90,6 +91,13 @@ end | |||
| function _M:rewrite(context) | |||
| local soap_action_uri = extract_soap_uri() | |||
|
|
|||
| -- If the soap_action_uri is a complete url, the mapping rule is only the | |||
There was a problem hiding this comment.
I'm missing something. How is this change in the SOAP policy related to the original issue?
There was a problem hiding this comment.
The action in the content-type can be a full url, so we need to pass it correctly:
APIcast/spec/policy/soap/soap_spec.lua
Lines 112 to 115 in 1266bc8
davidor
approved these changes
Jan 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the work make in APIAP, the double slash can happen quite easily,
as described in THREESCALE-3950. With this commit, when a new
mapping_rule is defined, double slash will be simplified to one to be
able to match with ngx.var.uri.
FIX THREESCALE-3950
Signed-off-by: Eloy Coto eloy.coto@gmail.com