Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Roverfile.lock with newer version of busted #1483

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Update Roverfile.lock with newer version of busted #1483

merged 1 commit into from
Jul 9, 2024

Conversation

tkan145
Copy link
Contributor

@tkan145 tkan145 commented Jul 9, 2024

CI failed to download dependencies with the following error

/usr/local/openresty/luajit/bin/luajit-2.1.0-beta3: /usr/share/lua/5.1/rover/install.lua:59: Error fetching file: Failed downloading http://dkolf.de/src/dkjson-lua.fsl/tarball/dkjson-2.6.tar.gz?uuid=release_2_6 - dkjson-2.6.tar.gz
stack traceback:
        [C]: in function 'assert'
        /usr/share/lua/5.1/rover/install.lua:59: in function 'install'
        /usr/share/lua/5.1/rover/install.lua:102: in function 'call'
        /usr/share/lua/5.1/rover/cli/install.lua:42: in function </usr/share/lua/5.1/rover/cli/install.lua:19>
        /usr/share/lua/5.1/rover/cli.lua:33: in function </usr/share/lua/5.1/rover/cli.lua:27>
        /usr/lib64/luarocks/rocks/lua-rover/scm-1/bin/rover:8: in main chunk
        [C]: at 0x5654138087a0
make: *** [Makefile:226: lua_modules] Error 1

dkjson is a dependency of busted. The version of busted is not pinned in Roverfile so upgrade Roverfile.lock is enough to pull in newer version.

@tkan145
Update busted
ea93b6f 
CI failed to download dependencies from
http://dkolf.de/src/dkjson-lua.fsl/tarball/dkjson-2.6.tar.gz?uuid=release_2_6.

The endpoint for version 2.6 seems to no longer exist so upgrading busted
to use newer dkjson version
@tkan145 tkan145 requested a review from a team as a code owner July 9, 2024 05:51
@tkan145 tkan145 merged commit 348195a into 3scale:master Jul 9, 2024
14 checks passed
@tkan145 tkan145 deleted the update-busted branch July 9, 2024 07:58
@tkan145 tkan145 mentioned this pull request Jul 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eguzki eguzki eguzki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tkan145 @eguzki