Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

policy manifests: replace descriptions with titles in OneOfs #663

Merged
merged 1 commit into from
Apr 4, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](http://keepachangelog.com/)
and this project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]

### Changed

- descriptions in `oneOf`s in policy manifests have been replaced with titles [PR #663](https://github.com/3scale/apicast/pull/663)

## [3.2.0-beta3] - 2018-03-20

### Fixed
Expand Down
8 changes: 4 additions & 4 deletions gateway/src/apicast/policy/caching/apicast-policy.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,19 +28,19 @@
"oneOf": [
{
"enum": ["resilient"],
"description": "Authorize according to last request when backend is down."
"title": "Authorize according to last request when backend is down."
},
{
"enum": ["strict"],
"description": "It only caches authorized calls."
"title": "Cache only authorized calls."
},
{
"enum": ["allow"],
"description": "When backend is down, allow everything unless seen before and denied."
"title": "When backend is down, allow everything unless seen before and denied."
},
{
"enum": ["none"],
"description": "Disables caching."
"title": "Disable caching."
}
]
}
Expand Down
4 changes: 2 additions & 2 deletions gateway/src/apicast/policy/echo/apicast-policy.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@
"oneOf": [
{
"enum": ["request"],
"description": "Interrupts the processing of the request."
"title": "Interrupt the processing of the request."
},
{
"enum": ["set"],
"description": "Only skips the rewrite phase."
"title": "Skip only the rewrite phase."
}
]
}
Expand Down
6 changes: 3 additions & 3 deletions gateway/src/apicast/policy/headers/apicast-policy.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,15 @@
"oneOf": [
{
"enum": ["add"],
"description": "Adds a value to an existing header."
"title": "Add a value to an existing header."
},
{
"enum": ["set"],
"description": "Creates the header when not set, replaces its value when set."
"title": "Create the header when not set, replace its value when set."
},
{
"enum": ["push"],
"description": "Creates the header when not set, adds the value when set."
"title": "Create the header when not set, add the value when set."
}
]
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,11 @@
"oneOf": [
{
"enum": ["sub"],
"description": "Substitutes the first match of the regex applied."
"title": "Substitute the first match of the regex applied."
},
{
"enum": ["gsub"],
"description": "Substitutes all the matches of the regex applied."
"title": "Substitute all the matches of the regex applied."
}
]
},
Expand Down