[proxy] refactor post_post action #775
Conversation
| local formatted_usage = format_usage(self.usage) | ||
| ngx.timer.at(0, post_action, self, cached_key, backend, formatted_usage, self.credentials, response_codes_data()) | ||
|
|
||
| ngx.timer.at(0, handle_timer_post_action, self, timers, cached_key, backend, formatted_usage, credentials, response_codes_data()) |
There was a problem hiding this comment.
@davidor looks like this is missing self.extra_params_backend_authrep
There was a problem hiding this comment.
Good catch 👍
This means that the referrer filter policy does not work when using the experimental async reporting. I'll add a test and fix the issue.
|
@mikz The integration tests were failing because the detection of whether to skip the post action was not done correctly. I've pushed a commit with the fix. |
gateway/src/apicast/proxy.lua
Outdated
| ngx.log(ngx.INFO, '[async] skipping after action, no cached key') | ||
| return |
There was a problem hiding this comment.
😂
edit: just laughing at my poor "refactoring" :)
mikz
force-pushed
the
proxy-post-action-refactor
branch
from
286eb23
to
7de9e0d
Compare
| if not using_post_action then | ||
| timers:post(1) | ||
| if not using_sync_post_action then | ||
| semaphore:post(1) |
There was a problem hiding this comment.
I think this is really important when designing the resty.concurrent.task.
It needs to release the semaphore before continuing with the handler (that might terminate the request and the processing with ngx.exit) (even though I'm not sure how that behaves when executed in a timer)
* better naming: sync/async reporting * proxy:post_action - receives context object - no need for the `force` parameter * no need to trigger post_action from rewrite phase
mikz
force-pushed
the
proxy-post-action-refactor
branch
from
7de9e0d
to
10529e9
Compare
mikz
changed the title
Extracted from #774
Refactors
proxy:post_actionto ease changes in #774. Proxy post_action should receive a context and be called from just one point - the policy.