[oidc] fix reporting to backend when using OIDC [THREESCALE-1080] #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mikz what do you mean by 'simplified' backport? |
|
@davidor it does not port the whole post_action refactoring and passing context. It just properly updates 'self.credentials'. I consider this a bit dirty, but simpler approach. But appropriate in this situation of making minimal changes in patch releases. Will update the PR description. |
davidor
approved these changes
Jun 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes THREESCALE-1080
Simplified backport of #774 for 3.2 release.
This simpler backport does not rely or passing
contextobject frompost_actionphase toproxyobject, but rather just updatesproxy.credentialsafter they are transformed byoauth:transform_credentialsmethod. #774 relies on not storing the credentials in proxy at all and rather storing them only in thecontextobject.But for a purpose of a patch release it is better to make minimal changes and reduce risk of unintended changes of behaviour.