Fix error when loading a config with only some services using OIDC #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
APIcast crashes when loading a config where only some of the services use
OIDC.
The reason is that we created an array of OIDC configs with
size=number_of_services. Let's say we have 100 services and only the
50th has an OIDC config. In this case, we created this Lua table: { [50]
= oidc_config_here }.
The problem is that cjson raises an error when trying to convert a
sparse array like that into JSON.
Check
https://www.kyne.com.au/~mark/software/lua-cjson-manual.html#encode_sparse_array
for more details.
Assigning false instead of nil solves the issue.
davidor
force-pushed
the
fix-sparse-oidc-array
branch
from
8742e56
to
edb8ee8
Compare
mikz
approved these changes
Sep 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
APIcast crashes when loading a config where only some of the services use OIDC.
The reason is that we create an array of OIDC configs that has size=number_of_services. Depending on the number of services and the number of services that use OIDC, we might create a sparse array. cjson raises an error when trying to convert a sparse array. Check
https://www.kyne.com.au/~mark/software/lua-cjson-manual.html#encode_sparse_array
for more details.
This PR solves the issue by assigning elements of that array to false instead of nil to avoid creating sparse arrays.
Ref: https://issues.jboss.org/browse/THREESCALE-1289