Integrate Image Streams #4

maneta · 2018-02-19T17:34:58Z

ToDo:

Check postCommit in the Build (Split resolv.conf in lines APIcast#618)
set resource limits/requests
Update deployment documentation and place a Makefile
Prepare service for prometheus metrics.

Plus separating templates for easier Deployment

mikz · 2018-02-19T17:50:54Z

openshift/01-apicast-cloud-hosted-imagestream.yml

+  tags:
+  - name: latest
+    annotations:
+      openshift.io/display-name: Apicast Cloud Hosted (latest) 


s/Apicast/APIcast/ 😉

Oops I did it again :p

mikz · 2018-02-19T17:51:40Z

openshift/02-apicast-builder-imagestream.yml

+    app: apicast
+spec:
+  tags:
+  - name: builder


Maybe add the branch name to the tag name? So we know it is "master" and not some tag?

Good Idea 👍

mikz · 2018-02-19T17:53:13Z

openshift/04-deployment-template.yml

          imagePullPolicy: IfNotPresent
-          name: apicast
+          name: apicast-${RELEASE_REF}


There should be no need for containers to have a suffix no?

mikz · 2018-02-19T17:53:53Z

openshift/04-deployment-template.yml

-          image: "${APICAST_IMAGE}"
+            value: "http://apicast-mapping-service-${RELEASE_REF}/config"
+          - name: APICAST_OIDC_LOG_LEVEL
+            value: "${APICAST_OIDC_LOG_LEVEL}"


I think this does not need to be a Parameter.

Ok So I will place the env var with notice as default.

mikz · 2018-02-19T18:03:17Z

openshift/02-apicast-builder-imagestream.yml

+  - name: builder
+    from:
+      kind: DockerImage
+      name: quay.io/3scale/apicast:master-builder


Shuld this use https://docs.openshift.com/container-platform/3.6/architecture/core_concepts/builds_and_image_streams.html#image-stream-mappings-working-periodic ?

That could be set as https://docs.openshift.com/container-platform/3.6/rest_api/openshift_v1.html#v1-tagimportpolicy

Yes I think it is a good idea.

Same as APICast

maneta · 2018-02-20T09:12:00Z

openshift/04-deployment-template.yml

@@ -103,6 +110,13 @@ objects:
          - containerPort: 8090
            name: management
            protocol: TCP
+          resources:


@mikz Should we set the APICAST_WORKERS too?

Nope. APIcast autodetects number of requested CPU cores: 3scale/APIcast#600

mikz · 2018-02-20T09:15:26Z

openshift/02-apicast-builder-imagestream.yml

+  - name: master-builder
+    from:
+      kind: DockerImage
+      name: quay.io/3scale/apicast:master-builder


Would be good to have a comment pointing to how is this refreshed.
#4 (comment)

TBH, I don't know how quay.io/3scale/apicast:master-builder is refreshed either... Or are you talking about the scheduled imports from the registry?

Yep. Scheduled imports.

Those quay images are built when master branch is updated.

Done in 287e33c

mikz · 2018-02-20T09:17:07Z

openshift/04-deployment-template.yml

+        imageChangeParams:
+          automatic: true
+          containerNames:
+            - apicast-${RELEASE_REF} 


This looks wrong.

The ImageStream will immport the builder imager periodically. This configuration is clusterwide but the default is 15 minutes.

mikz · 2018-02-20T16:37:35Z

openshift/Makefile

+	oc new-app -f $(THISDIR_PATH)/04-deployment-template.yml \
+		-p RELEASE_REF=${RELEASE_REF} \
+		-p ENVIRONMENT=${ENVIRONMENT} \
+		-p CACHE_TTL=${CACHE_TTL} 


Will this crash when CACHE_TTL is empty? It should.

yes it crashes because there is no predefined value in the template.

Actually it brakes without RELEASE_REF AND ENVIRONMENT also.

The actuall error message:

oc new-app -f /Users/dcesario/src/apicast-cloud-hosted/openshift/04-deployment-template.yml \ -p RELEASE_REF=test-dani3 \ -p ENVIRONMENT=staging \ -p CACHE_TTL= error: error processing template "apicast-staging/apicast-cloud-hosted-deployment": Template "apicast-cloud-hosted-deployment" is invalid: template.parameters[2]: Required value: template.parameters[2]: parameter CACHE_TTL is required and must be specified make: *** [deploy] Error 1

maneta · 2018-02-20T16:39:52Z

@mikz Should we investigate how to build the apicast-mapping-service image or should we let it for the future (as an issue)?

maneta · 2018-02-20T16:38:07Z

openshift/03-build-config.yml

-      - '--daemon'
-    command:
-      - bin/apicast
+  #postCommit:


@mikz Should we remove the postCommit ? The Deployment is working without it, but I'm not sure how to solve it...

postCommit is good. It verifies the image will boot. Otherwise you have no idea until you try to deploy it (and fail).

Ok you said something about Apicasy and the RESOLVER env Variable I will take a look at it

@mikz So the problem with the postCommit is that the openshift builder is setting the resolv.conf file like that:

# nameserver updated by /etc/NetworkManager/dispatcher.d/99-origin-dns.sh # Generated by NetworkManager search ec2.internal cluster.local nameserver 10.0.101.97

The problem is the first line, looks like the parse_nameservers function in APIcast https://github.com/3scale/apicast/blob/5c2dc6bbf9295b5e7891fb7bb52e32abcf763972/gateway/src/resty/resolver.lua#L105 is matching with the commented nameserver in the file.

The actual error thrown by nginx is:

nginx: [emerg] invalid IPv6 address in resolver "[domain]:53" in /tmp/lua_c5D5o5:45

I have reproduced it locally.

Yep. Looks like: https://github.com/3scale/apicast/blob/5c2dc6bbf9295b5e7891fb7bb52e32abcf763972/gateway/src/resty/resolver.lua#L135-L140

This should match only from start of the line and ignore comments. We probably need better parsing anyway.

Good catch!

Corrected in 3scale/APIcast#618

maneta · 2018-02-28T12:29:36Z

@mikz please review 58d7958 when you can.

Introducing Imagestreams

61a7779

Plus separating templates for easier Deployment

maneta requested review from jmprusi and mikz February 19, 2018 17:36

mikz reviewed Feb 19, 2018

View reviewed changes

maneta added 2 commits February 20, 2018 09:49

PR #4 review requests.

9ed79a7

Introducing Resource Limits

6d67553

Same as APICast

maneta commented Feb 20, 2018

View reviewed changes

mikz reviewed Feb 20, 2018

View reviewed changes

maneta added 2 commits February 20, 2018 11:33

Scheduled Import builder image

287e33c

The ImageStream will immport the builder imager periodically. This configuration is clusterwide but the default is 15 minutes.

Makefile for deployment and Documentation Update

b3a3267

mikz reviewed Feb 20, 2018

View reviewed changes

maneta commented Feb 20, 2018

View reviewed changes

mikz mentioned this pull request Feb 21, 2018

issues with parsing resolv.conf 3scale/APIcast#617

Closed

maneta added 2 commits February 28, 2018 12:59

re-enabling postCommit in the BuildConfig

d917818

Adding prometheus exporter endpoint

58d7958

maneta changed the title ~~WIP - Integrate Image Streams~~ Integrate Image Streams Feb 28, 2018

maneta added 2 commits February 28, 2018 16:08

updating the postCommit to be more insightfull

dfb1371

specifying the port used to scrape

0b3dfe2

maneta merged commit 071ba51 into master Mar 6, 2018

maneta deleted the introduce-imagestreams branch March 6, 2018 16:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Integrate Image Streams #4

Integrate Image Streams #4

maneta commented Feb 19, 2018 •

edited

Loading

mikz Feb 19, 2018

maneta Feb 20, 2018

mikz Feb 19, 2018

maneta Feb 20, 2018

mikz Feb 19, 2018

maneta Feb 20, 2018

mikz Feb 19, 2018

maneta Feb 20, 2018

mikz Feb 19, 2018

mikz Feb 19, 2018

maneta Feb 20, 2018

maneta Feb 20, 2018

mikz Feb 20, 2018

maneta Feb 20, 2018

mikz Feb 20, 2018

maneta Feb 20, 2018

mikz Feb 20, 2018

maneta Feb 20, 2018

mikz Feb 20, 2018

maneta Feb 20, 2018

mikz Feb 20, 2018

maneta Feb 20, 2018

mikz Feb 20, 2018

maneta commented Feb 20, 2018

maneta Feb 20, 2018

mikz Feb 20, 2018

maneta Feb 20, 2018 •

edited

Loading

maneta Feb 21, 2018 •

edited by mikz

Loading

mikz Feb 21, 2018

maneta Feb 28, 2018

maneta commented Feb 28, 2018 •

edited

Loading

Integrate Image Streams #4

Integrate Image Streams #4

Conversation

maneta commented Feb 19, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

maneta commented Feb 20, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

maneta Feb 20, 2018 • edited Loading

Choose a reason for hiding this comment

maneta Feb 21, 2018 • edited by mikz Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

maneta commented Feb 28, 2018 • edited Loading

maneta commented Feb 19, 2018 •

edited

Loading

maneta Feb 20, 2018 •

edited

Loading

maneta Feb 21, 2018 •

edited by mikz

Loading

maneta commented Feb 28, 2018 •

edited

Loading