policy manifests: replace descriptions with titles in OneOfs #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikz
approved these changes
Apr 4, 2018
didierofrivia
approved these changes
Apr 4, 2018
The reason is that the library used in the UI to render policy configs does not show descriptions, but it shows titles. From an APIcast point of view I don't see a difference, so I think this change should be OK.
davidor
force-pushed
the
replace-descriptions-with-titles-manifests
branch
from
66cfe68
to
4f3bbd9
Compare
|
Added a changelog entry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a change proposed by @ddcesare
The reason is that the library used in the UI to render policy configs does not show descriptions, but it shows titles.
From an APIcast point of view I don't see a difference, so I think this should be OK.