Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #16 #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixes #16 #18

wants to merge 1 commit into from

Conversation

asharpe
Copy link

@asharpe asharpe commented Oct 3, 2022 •
edited by eguzki
Loading

Fixes #16

eguzki
eguzki approved these changes Oct 17, 2022
View reviewed changes
spec/resty/url_spec.lua
@@ -23,7 +23,7 @@ describe('resty.url', function()
local split = url.split

it('works with port', function()
assert.same({'https', false, false, 'example.com', '8443'},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

spec/resty/url_spec.lua
@@ -63,7 +63,7 @@ describe('resty.url', function()
end)

it('works with port and path', function()
assert.same({'http', false, false, 'example.com', '8080', '/path'},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

spec/resty/url_spec.lua
@@ -78,12 +78,12 @@ describe('resty.url', function()
end)

it('works with IPv4 host', function()
assert.same({'https', false, false, '195.47.235.3', '443', '/path'},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

spec/resty/url_spec.lua
split('https://195.47.235.3:443/path'))
end)

it('works with IPv6 host', function()
assert.same({'https', false, false, '[2a02:38::1001]', '443', '/path'},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eguzki eguzki eguzki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

parse error
2 participants
@asharpe @eguzki