[api] attributes base_url and admin_url to account #1869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Martouta
previously approved these changes
May 11, 2020
hallelujah
previously approved these changes
May 27, 2020
guicassolato
force-pushed
the
api/admin-and-portal-urls
branch
from
abc6914 to
1fded31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces two new attributes in the representation of account objects in the admin API responses:
base_urlandadmin_base_url. These correspond to the existingdomainandadmin_domainattributes prepended with the current HTTP scheme of the system (http or https) to make them full URLs, instead of just domain names.In particular, this change will allow Zync to resolve which TLS configuration to apply to the Kubernetes/OpenShift routes it manages for the accounts, without having to rely on a default.
Related to THREESCALE-4832.