👷 Disable Eslint in Codeclimate #3104
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlledom
previously approved these changes
Nov 10, 2022
|
juts fix code climate |
|
codeclimate issue is rather strange |
josemigallas
dismissed stale reviews from nidhi-soni1104 and jlledom
via
f399d64
josemigallas
force-pushed
the
disable_eslint_codeclimate
branch
from
9ad1628
to
f399d64
Compare
I think my fork was missing a rebase. EDIT: it wasn't that. It seems the Eslint check is still running even thought the plugin is disabled. I've contacted codeclimate... |
josemigallas
force-pushed
the
disable_eslint_codeclimate
branch
from
f399d64
to
fb5e427
Compare
josemigallas
force-pushed
the
disable_eslint_codeclimate
branch
from
fb5e427
to
ea5632c
Compare
josemigallas
force-pushed
the
disable_eslint_codeclimate
branch
from
6228ae8
to
ee9f196
Compare
|
maybe they don't read config from fork branches - only from main repo. Like circleci |
I created a branch in the original repo (#3106) and it's still not working 😕 The only explanation possible is that plugin cannot be disabled. |
|
Already merged in #3106 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already run the same command in Circleci.