Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THREESCALE-11544: Set active_support.cache_format_version to 7.0 #4032

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jlledom
Copy link
Contributor

@jlledom jlledom commented Mar 4, 2025

What this PR does / why we need it:

Rails 7 is deployed and apparently everything went well. It doesn't seem we are rolling back, so we can set Rails cache format to 7.0

Which issue(s) this PR fixes

https://issues.redhat.com/browse/THREESCALE-11544

Verification steps

Everything should work as usual

@jlledom jlledom requested a review from mayorova March 4, 2025 15:48
@jlledom jlledom self-assigned this Mar 5, 2025
@jlledom jlledom marked this pull request as draft March 5, 2025 10:04
Copy link
Contributor

@akostadinov akostadinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this invalidate current sessions?

@akostadinov
Copy link
Contributor

Probably not. Just a question which cache will be affected.

@jlledom
Copy link
Contributor Author

jlledom commented Mar 5, 2025

Will this invalidate current sessions?

I don't think so, sessions are in DB, right?

@akostadinov
Copy link
Contributor

right, do you know what does this cache break though? Just a question if you happen to know. I'll check out later if not.

@jlledom
Copy link
Contributor Author

jlledom commented Mar 6, 2025

right, do you know what does this cache break though? Just a question if you happen to know. I'll check out later if not.

According to docs, nothing should break.

https://guides.rubyonrails.org/v7.0/upgrading_ruby_on_rails.html#new-activesupport-cache-serialization-format

Rails 7.0 is able to read both formats so the cache won't be invalidated during the upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants