🧹 Clean up jquery rails

[josemigallas]

TL;DR

UPDATE: It was not so simple!

Description

Forms and other asynchronous stuff is managed by rails-ujs (Unobtrusive scripting adapter for jQuery).

It is embedded in the jQuery imported as gem jquery-rails as following:

//= require jquery
//= require jquery_ujs

In recent rails (5+), rails-ujs is included in the gem rails and it's imported like this:

//= require jquery
//= require rails-ujs

Moreover rails-jquery includes jquery 1, 2 and 3:

//= require jquery
//= require jquery2
//= require jquery3

Therefore, the best way to unify jquery 1 is to remove all other from assets/vendor and just use the one provided by this gem.
Webpack packages will still use jQuery 3.x from node_modules and there's even a node module for rails-ujs... so in time we'll see wether we stick to Gem of NPM.

[jlledom]

Can't compile assets:

Sprockets::FileNotFound: couldn't find file 'vendor/jquery-1.11.3.min.js' with type 'application/javascript'

[mayorova]

OMG, why did we have googleapis in the first place??!

Looks like there is still some leftover:

porta/app/views/stats/days/show.html.erb

Line 1 in 36eeb45

<script src="//ajax.googleapis.com/ajax/libs/swfobject/2.2/swfobject.js" type="text/javascript"></script>

I think in the next PR we'd need to remove both this helper, and that external JS.

[jlledom]

Works apparently fine for me 👍