-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[proxy] introduce OIDC integration types [THREESCALE-2665] #829
Conversation
app/views/api/integrations/apicast/shared/_authentication_settings.html.slim
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally approve, small changes
21f645e
to
682ee92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation change then it will be complete
@@ -76,7 +76,7 @@ def proxy_params | |||
error_status_auth_failed error_status_auth_failed error_headers_auth_failed | |||
error_status_auth_missing error_headers_auth_missing error_no_match | |||
error_status_no_match error_headers_no_match secret_token hostname_rewrite | |||
oauth_login_url api_test_path oidc_issuer_endpoint] | |||
oauth_login_url api_test_path oidc_issuer_endpoint oidc_issuer_type] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add it to the documentation
##~ op.parameters.add name: "oidc_issuer_endpoint", description: "Location of your OpenID Provider.", dataType: "string", paramType: "query", required: false |
Codecov Report
@@ Coverage Diff @@
## master #829 +/- ##
=========================================
- Coverage 92.94% 92.3% -0.64%
=========================================
Files 2421 2318 -103
Lines 78659 73882 -4777
=========================================
- Hits 73107 68195 -4912
- Misses 5552 5687 +135
Continue to review full report at Codecov.
|
What this PR does / why we need it:
Adds a select box for user chose if they are using Keycloak or Generic HTTP adapter for the OIDC sync integration.