Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proxy] introduce OIDC integration types [THREESCALE-2665] #829

Merged
merged 1 commit into from
Jun 11, 2019

Conversation

mikz
Copy link
Contributor

@mikz mikz commented May 31, 2019

What this PR does / why we need it:

Adds a select box for user chose if they are using Keycloak or Generic HTTP adapter for the OIDC sync integration.

@hallelujah hallelujah added Priority: High Closes a JIRA issue in our sprint ruby Pull requests that update Ruby code labels Jun 5, 2019
app/models/proxy.rb Outdated Show resolved Hide resolved
app/models/proxy.rb Outdated Show resolved Hide resolved
hallelujah
hallelujah previously approved these changes Jun 5, 2019
Copy link
Contributor

@hallelujah hallelujah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally approve, small changes

@mikz mikz force-pushed the zync-generic-http branch 4 times, most recently from 21f645e to 682ee92 Compare June 6, 2019 09:20
Copy link
Contributor

@hallelujah hallelujah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation change then it will be complete

@@ -76,7 +76,7 @@ def proxy_params
error_status_auth_failed error_status_auth_failed error_headers_auth_failed
error_status_auth_missing error_headers_auth_missing error_no_match
error_status_no_match error_headers_no_match secret_token hostname_rewrite
oauth_login_url api_test_path oidc_issuer_endpoint]
oauth_login_url api_test_path oidc_issuer_endpoint oidc_issuer_type]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add it to the documentation

##~ op.parameters.add name: "oidc_issuer_endpoint", description: "Location of your OpenID Provider.", dataType: "string", paramType: "query", required: false

@mikz mikz force-pushed the zync-generic-http branch from 682ee92 to 17bbfd2 Compare June 6, 2019 10:30
hallelujah
hallelujah previously approved these changes Jun 6, 2019
@codecov
Copy link

codecov bot commented Jun 7, 2019

Codecov Report

Merging #829 into master will decrease coverage by 0.63%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #829      +/-   ##
=========================================
- Coverage   92.94%   92.3%   -0.64%     
=========================================
  Files        2421    2318     -103     
  Lines       78659   73882    -4777     
=========================================
- Hits        73107   68195    -4912     
- Misses       5552    5687     +135
Impacted Files Coverage Δ
...ntrollers/admin/api/services/proxies_controller.rb 100% <ø> (ø) ⬆️
app/representers/proxy_representer.rb 100% <100%> (ø) ⬆️
test/unit/proxy_test.rb 100% <100%> (ø) ⬆️
app/controllers/api/integrations_controller.rb 75.36% <100%> (+0.54%) ⬆️
app/models/proxy.rb 97.27% <80%> (-0.28%) ⬇️
app/lib/logic/nginx_proxy.rb 27.27% <0%> (-72.73%) ⬇️
lib/last_traffic.rb 33.33% <0%> (-66.67%) ⬇️
lib/range_hacks.rb 37.5% <0%> (-62.5%) ⬇️
...provider/admin/api_docs/account_data_controller.rb 40% <0%> (-60%) ⬇️
app/mailers/data_export_mailer.rb 40% <0%> (-60%) ⬇️
... and 201 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79c87d2...924a4e0. Read the comment docs.

@hallelujah hallelujah marked this pull request as ready for review June 11, 2019 12:36
@hallelujah hallelujah merged commit 043e8e7 into master Jun 11, 2019
@hallelujah hallelujah deleted the zync-generic-http branch June 11, 2019 12:37
hallelujah added a commit that referenced this pull request Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High Closes a JIRA issue in our sprint ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants