Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding data-name="$post->post_name" for more symantic js if needed #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dannyb195
Copy link

$post->post_name = slug (most of the time as far as I can tell)

@joshbroton
Copy link
Member

Dan, I LOVE this idea, and am adding it to a site I'm working on now, but it violates our "only if absolutely necessary" rule about functionality for our vanilla theme. You know what would be AWESOME, though? This as a plugin.

I could see a plugin with a checkbox list where you turn on data-* attributes, like data-title, data-id, data-position-on-page, data-author, data-author-id, data-categories, data-date-published, and more (cant think of any more right now). I've added a universal-plugins repo. Want to play with that idea? Just fork it, add a folder for the plugin, and code away. We can all add as we think of some that would be useful sometime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants