generated from 3ware/workflows
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(mergeq): Test merge queue workflow #51
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💰 Infracost reportMonthly estimate decreased by £228 📉
*Usage costs were estimated using Infracost Cloud settings, see docs for other options. Estimate details
|
3c82b53
to
3a54436
Compare
terraform apply -chdir='terraform/development/vpc' Diff of changes.+ module.vpc.aws_db_subnet_group.database[0] will be created
+ module.vpc.aws_default_network_acl.this[0] will be created
+ module.vpc.aws_default_route_table.default[0] will be created
+ module.vpc.aws_default_security_group.this[0] will be created
+ module.vpc.aws_internet_gateway.this[0] will be created
+ module.vpc.aws_route.public_internet_gateway[0] will be created
+ module.vpc.aws_route_table.private[0] will be created
+ module.vpc.aws_route_table.private[1] will be created
+ module.vpc.aws_route_table.private[2] will be created
+ module.vpc.aws_route_table.public[0] will be created
+ module.vpc.aws_route_table_association.database[0] will be created
+ module.vpc.aws_route_table_association.database[1] will be created
+ module.vpc.aws_route_table_association.database[2] will be created
+ module.vpc.aws_route_table_association.private[0] will be created
+ module.vpc.aws_route_table_association.private[1] will be created
+ module.vpc.aws_route_table_association.private[2] will be created
+ module.vpc.aws_route_table_association.public[0] will be created
+ module.vpc.aws_route_table_association.public[1] will be created
+ module.vpc.aws_route_table_association.public[2] will be created
+ module.vpc.aws_subnet.database[0] will be created
+ module.vpc.aws_subnet.database[1] will be created
+ module.vpc.aws_subnet.database[2] will be created
+ module.vpc.aws_subnet.private[0] will be created
+ module.vpc.aws_subnet.private[1] will be created
+ module.vpc.aws_subnet.private[2] will be created
+ module.vpc.aws_subnet.public[0] will be created
+ module.vpc.aws_subnet.public[1] will be created
+ module.vpc.aws_subnet.public[2] will be created
+ module.vpc.aws_vpc.this[0] will be created Apply complete! Resources: 29 added, 0 changed, 0 destroyed.
|
No need to specify in terraform.tfvars now as using directories.
terraform apply -chdir='terraform/production/vpc' Diff of changes.+ module.vpc.aws_db_subnet_group.database[0] will be created
+ module.vpc.aws_default_network_acl.this[0] will be created
+ module.vpc.aws_default_route_table.default[0] will be created
+ module.vpc.aws_default_security_group.this[0] will be created
+ module.vpc.aws_internet_gateway.this[0] will be created
+ module.vpc.aws_route.public_internet_gateway[0] will be created
+ module.vpc.aws_route_table.private[0] will be created
+ module.vpc.aws_route_table.private[1] will be created
+ module.vpc.aws_route_table.private[2] will be created
+ module.vpc.aws_route_table.public[0] will be created
+ module.vpc.aws_route_table_association.database[0] will be created
+ module.vpc.aws_route_table_association.database[1] will be created
+ module.vpc.aws_route_table_association.database[2] will be created
+ module.vpc.aws_route_table_association.private[0] will be created
+ module.vpc.aws_route_table_association.private[1] will be created
+ module.vpc.aws_route_table_association.private[2] will be created
+ module.vpc.aws_route_table_association.public[0] will be created
+ module.vpc.aws_route_table_association.public[1] will be created
+ module.vpc.aws_route_table_association.public[2] will be created
+ module.vpc.aws_subnet.database[0] will be created
+ module.vpc.aws_subnet.database[1] will be created
+ module.vpc.aws_subnet.database[2] will be created
+ module.vpc.aws_subnet.private[0] will be created
+ module.vpc.aws_subnet.private[1] will be created
+ module.vpc.aws_subnet.private[2] will be created
+ module.vpc.aws_subnet.public[0] will be created
+ module.vpc.aws_subnet.public[1] will be created
+ module.vpc.aws_subnet.public[2] will be created
+ module.vpc.aws_vpc.this[0] will be created Apply complete! Resources: 29 added, 0 changed, 0 destroyed.
|
james3ware
previously approved these changes
Oct 25, 2024
Why isn't this auto merging when all requirements are met? |
james3ware
approved these changes
Oct 28, 2024
This PR is included in version 1.6.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to experiment with merge queues. It appears that you need to click the "merge when ready" button before the PR is approved or all checks have passed - when the PR is dirty!. If the PR is clean i.e approved and all checks have passed then you get an error:
Or from the CLI:
enable auto-merge has been ticked in the repository settings.