Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update helpers.php #105

Merged
merged 2 commits into from
Jun 15, 2020
Merged

Update helpers.php #105

merged 2 commits into from
Jun 15, 2020

Conversation

matiullah31
Copy link
Contributor

In case user model primary key name is not 'id'

@matiullah31
Update helpers.php
0f127af 
In case user model primary key name is not 'id'
@MarceauKa
Copy link
Member

We should use app('auth')->guard($guard)->user()->getAuthIdentifier() rather than app('auth')->guard($guard)->user()->{app('auth')->guard($guard)->user()->getkeyName()}

@matiullah31
Update helpers.php
b888b1f 
Get Auth user identifier using getAuthIdentifier()
@matiullah31
Copy link
Contributor Author

We should use app('auth')->guard($guard)->user()->getAuthIdentifier() rather than app('auth')->guard($guard)->user()->{app('auth')->guard($guard)->user()->getkeyName()}

@MarceauKa I have updated that.

lloricode
lloricode suggested changes May 16, 2020
View reviewed changes
Copy link
Contributor

@lloricode lloricode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be easily check changes, you should not commit does not necessary like format changes

@MarceauKa MarceauKa merged commit 592ff94 into 404labfr:master Jun 15, 2020
nickclickmyads pushed a commit to Vendin/laravel-impersonate that referenced this pull request Sep 10, 2020
@matiullah31 @nickclickmyads
Update helpers.php (404labfr#105)
51727a7 
* Update helpers.php

In case user model primary key name is not 'id'

* Update helpers.php

Get Auth user identifier using getAuthIdentifier()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lloricode lloricode lloricode requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matiullah31 @MarceauKa @lloricode