Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add City of Bones #83

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add City of Bones #83

wants to merge 1 commit into from

Conversation

allie-p
Copy link

@allie-p allie-p commented Oct 19, 2019

Please check all tasks that you've completed by placing an x within the square braces below.

Proposed Changes

  • I've read the CODE OF CONDUCT and abide to it.
  • I've read the CONTRIBUTING.md
  • I've forked the repository.
  • I've created a branch and made my changes in it.
  • I understand opening a PULL REQUEST doesn't mean it will be merged for sure.

Fixes issue

Fixes #72

swingcake
swingcake suggested changes Oct 24, 2019
View reviewed changes
books/city-of-bones.json
],
"characters": ["Clary Fray, Jace Herondale", "Alec Lightwood"],
"pages": 485,
"ISBN": " 978-1-4169-5507-8",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the blank spaces present in ISBN number.

books/city-of-bones.json
"Fantasy Fiction",
"Adventure Fiction"
],
"characters": ["Clary Fray, Jace Herondale", "Alec Lightwood"],
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enter each "character" in a new line for better code consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swingcake swingcake swingcake requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add City of Bones by Cassandra Clare
2 participants
@allie-p @swingcake