Verify that there is space in party/boxes before running modes that catch Pokémon #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atch Pokémon This adds a new assertion, `assert_boxes_or_party_can_fit_pokemon()`, which will verify that there is at least one empty slot in either the party or one of the boxes. This assertion is used in each mode that is meant to find shinies (i.e. it's not checked in modes like Level Grind and EV Train -- even though they _could_ also encounter shinies that's not their primary purpose.) I've also updated the `assert_player_has_poke_balls()` check in some modes that use soft resets to check the saved game and not the currently running one, as that's the actually important part.
pekempy
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a new assertion,
assert_boxes_or_party_can_fit_pokemon(), which will verify that there is at least one empty slot in either the party or one of the boxes. (Because if there isn't, a Pokémon cannot be caught which would be a bit sad.)This assertion is used in each mode that is meant to find shinies (i.e. it's not checked in modes like Level Grind and EV Train -- even though they could also encounter shinies that's not their primary purpose.)
I've also updated the
assert_player_has_poke_balls()check in some modes that use soft resets to check the saved game and not the currently running one, as that's the actually important part.Checklist
--line-length 120argument