Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: input empty div, framer preview bug #126

Merged
merged 3 commits into from
Jul 22, 2023
Merged

Conversation

Seojunhwan
Copy link
Member

바뀐점

  • topAddon이 없을 때 해당 영역 div를 렌더링하지 않도록 수정합니다.
  • framer preview 모드에서 input value가 변경되지 않던 문제를 수정합니다.

바꾼이유

  • QA?,,

설명

framer control panel에서 value:"" 형식으로 기본값을 제공하는데, 해당 기본값으로 인해 input이 controlled 로 동작한 것 같아요.
framer layer에서 상태 하나 집어넣어서 값이 변경되도록 수정합니당

Close #123 #124

@Seojunhwan Seojunhwan requested a review from a team July 9, 2023 13:36
@Seojunhwan Seojunhwan self-assigned this Jul 9, 2023
@github-actions
Copy link

github-actions bot commented Jul 9, 2023

Alpha pages have been removed.

0.24.1-alpha126-d125560
0.25.3-alpha126-d86597c
0.25.4-alpha126-4ed8bb7

@asdf99245
Copy link
Contributor

준서좌 제가 테스트해보았을 때는 framer에서 value가 안들어가여

@Seojunhwan
Copy link
Member Author

Seojunhwan commented Jul 16, 2023

준서좌 제가 테스트해보았을 때는 framer에서 value가 안들어가여

요거 배포된 알파가 조금 이상한 것처럼 보이네용,, 반영이 안 된 것 같은데, 로컬에서 돌려보면 아래 영상처럼 보여요 ㅠㅠ

2023-07-16.21.42.04.mov

@Skyrich2000
Copy link
Member

이왜진 흠....

@asdf99245
Copy link
Contributor

헉걱걱 그럼일단 merge 해도 될려나여

@Seojunhwan Seojunhwan merged commit 677c75a into main Jul 22, 2023
@Seojunhwan Seojunhwan deleted the fix/label-empty-div#123 branch July 22, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] input 에서 label 빈문자열 넣으면 input 컴포넌트 위에 빈 div가 남아있어요
3 participants