Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: User sign in a loop if callbackurl is set to login page #85

Closed
42atomys opened this issue Apr 30, 2022 · 0 comments · Fixed by #91
Closed

fix: User sign in a loop if callbackurl is set to login page #85

42atomys opened this issue Apr 30, 2022 · 0 comments · Fixed by #91
Labels
aspect/interface 🕹 Concerns end-users' experience with the software domain/obvious 🟩 Represents the "known knowns" issue. It's Obviously good first issue Good for newcomers priority/medium 🟨 Priority 3 - Not blocking but should be fixed soon type/bug 🔥 Something isn't working
Milestone
3.0 Beta Release 👷

Comments

@42atomys
Copy link
Owner

Describe the bug
When an User sign in in app and get an Error during login or have callbackUrl set to auth page link. After the user is connected, the User is redirected to the login page and needs to edut URL manually.

To Reproduce
Steps to reproduce the behavior:

  1. Go to http://localhost:3000/auth/signin?callbackUrl=/auth/login
  2. Sign In with 42

Expected behavior
When a connected user try to go /auth/signin and he is already connected, redirect the user to /
@42atomys 42atomys added priority/medium 🟨 Priority 3 - Not blocking but should be fixed soon aspect/interface 🕹 Concerns end-users' experience with the software domain/obvious 🟩 Represents the "known knowns" issue. It's Obviously type/bug 🔥 Something isn't working labels Apr 30, 2022
@42atomys 42atomys added this to the 3.0 Beta Release 👷 milestone Apr 30, 2022
@github-actions github-actions bot added the state/triage 🚦 Has not been triaged & therefore, not ready for work label Apr 30, 2022
@42atomys 42atomys added good first issue Good for newcomers and removed state/triage 🚦 Has not been triaged & therefore, not ready for work labels Apr 30, 2022
@rgaiffe rgaiffe linked a pull request May 3, 2022 that will close this issue
85 fix user sign in a loop if callbackurl is set to login page #91
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
aspect/interface 🕹 Concerns end-users' experience with the software domain/obvious 🟩 Represents the "known knowns" issue. It's Obviously good first issue Good for newcomers priority/medium 🟨 Priority 3 - Not blocking but should be fixed soon type/bug 🔥 Something isn't working
Projects
Stud42 V3
Status: Done 🎉
Milestone
3.0 Beta Release 👷
Development

Successfully merging a pull request may close this issue.

85 fix user sign in a loop if callbackurl is set to login page 42atomys/stud42
1 participant
@42atomys