Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

85 fix user sign in a loop if callbackurl is set to login page #91

Merged
merged 3 commits into from
May 3, 2022
Merged

85 fix user sign in a loop if callbackurl is set to login page #91

merged 3 commits into from
May 3, 2022

Conversation

rgaiffe
Copy link
Collaborator

@rgaiffe rgaiffe commented May 3, 2022 •
edited
Loading

Describe the pull request
Resolve the issue

Checklist

  • I have linked the relative issue to this pull request
  • I have made the modifications or added tests related to my PR
  • I have added/updated the documentation for my RP
  • I put my PR in Ready for Review only when all the checklist is checked

Breaking changes ?
no

@rgaiffe rgaiffe linked an issue May 3, 2022 that may be closed by this pull request
fix: User sign in a loop if callbackurl is set to login page #85
Closed
@rgaiffe rgaiffe requested a review from 42atomys as a code owner May 3, 2022 15:54
@github-actions github-actions bot added the sponsor 💖 This is created be a sponsor of project label May 3, 2022
42atomys
42atomys approved these changes May 3, 2022
View reviewed changes
Copy link
Owner

@42atomys 42atomys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice for your first typescript contribution 🎉

@42atomys 42atomys merged commit 657c5ed into main May 3, 2022
@42atomys 42atomys deleted the 85-fix-user-sign-in-a-loop-if-callbackurl-is-set-to-login-page branch May 3, 2022 16:02
42atomys pushed a commit that referenced this pull request Nov 12, 2022
@rgaiffe
85 fix user sign in a loop if callbackurl is set to login page (#91)
ef027f5 
* fix: Config path example

* fix: Block auth page if user is logged

* test

Co-authored-by: Grumbleur <remi.gaiffe@googlemail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@42atomys 42atomys 42atomys approved these changes

Assignees
No one assigned
Labels
sponsor 💖 This is created be a sponsor of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: User sign in a loop if callbackurl is set to login page
2 participants
@rgaiffe @42atomys