Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cluster): integrate 42 urduliz campus #531

Merged
merged 5 commits into from
Oct 19, 2023

Conversation

samuelcordero
Copy link
Contributor

Describe the pull request

Added 42 Urduliz cluster map integration

Checklist

  • [*] I have made the modifications or added tests related to my PR
  • [*] I have run the tests and linters locally and they pass
  • [*] I have added/updated the documentation for my RP

Additional context

Copy link
Contributor Author

@samuelcordero samuelcordero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected indent

@42atomys 42atomys linked an issue Oct 13, 2023 that may be closed by this pull request
1 task
@42atomys
Copy link
Owner

Hi @samuelcordero

Firstly, thank you for taking the time to contribute to S42! 🎉
⚠️ The CI failed in linting can you fix it please ? (yarn make-pretty will do the job)

🕐 I need to check the interface and I dont have my laptop in hand currently. I'll keep the pull request open and will merge it as soon as I reviewed.

Once again, thanks for your contribution, and please feel free to reach me and others contributors on the Discord if you have any questions or if there's anything else you'd like to discuss 😄

@samuelcordero samuelcordero force-pushed the feat-urduliz-integration branch 2 times, most recently from b47eeeb to 56b58a8 Compare October 14, 2023 16:25
@samuelcordero
Copy link
Contributor Author

Hi @42atomys,
Thank you for everything! I hope it is okay now, linting reported 0 problems, 0 warnings. I'll be joining the discord, I'd love to be in touch with everyone involved. Have a nice day!

Copy link
Owner

@42atomys 42atomys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉
Thanks for your first contribution again, this will be released soon !

@42atomys 42atomys merged commit 598cd75 into 42atomys:main Oct 19, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: integrate urduliz campus
2 participants