Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Create monitoring Prometheus with operator #79

Merged
merged 5 commits into from
May 4, 2022
Merged

feat: Create monitoring Prometheus with operator #79

merged 5 commits into from
May 4, 2022

Conversation

rgaiffe
Copy link
Collaborator

@rgaiffe rgaiffe commented Apr 28, 2022 •
edited
Loading

Relative Issues:

Deploy monitoring with 5 components:

  • Prometheus
  • Node exporter
  • Grafana
  • Kube States Metrics
  • Alert manager

Describe the pull request

Deploy monitoring stack

Checklist

  • I have linked the relative issue to this pull request
  • I have made the modifications or added tests related to my PR
  • I have added/updated the documentation for my RP
  • I put my PR in Ready for Review only when all the checklist is checked

Breaking changes ?
no

Additional context
None

@rgaiffe rgaiffe requested a review from 42atomys as a code owner April 28, 2022 21:24
@rgaiffe rgaiffe self-assigned this Apr 28, 2022
@github-actions github-actions bot added the sponsor 💖 This is created be a sponsor of project label Apr 28, 2022
@rgaiffe rgaiffe linked an issue Apr 28, 2022 that may be closed by this pull request
feat: Create monitoring Prometheus with operator #80
Closed
@rgaiffe rgaiffe added this to the 3.0 Beta Release 👷 milestone Apr 28, 2022
42atomys
42atomys requested changes Apr 28, 2022
View reviewed changes
Copy link
Owner

@42atomys 42atomys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+57k additions cannot be reviewed and maintained by simple action.

Maybe make a script or ci action to generate file on the fly with remote strategy.

@42atomys 42atomys self-requested a review April 29, 2022 20:26
42atomys
42atomys approved these changes May 3, 2022
View reviewed changes
Copy link
Owner

@42atomys 42atomys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@42atomys 42atomys merged commit 37b17dc into main May 4, 2022
@42atomys 42atomys deleted the rgaiffe/add-monitoring branch May 4, 2022 16:39
42atomys added a commit that referenced this pull request Nov 12, 2022
@rgaiffe @42atomys
feat: Create monitoring Prometheus with operator (#79)
558b9a0 
* feat: Create monitoring Prometheus with operator

* Remove all yaml file, replace by generating script

* Remove commentary in the template and write readme

Co-authored-by: Grumbleur <remi.gaiffe@googlemail.com>
Co-authored-by: 42Atomys <contact@atomys.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@42atomys 42atomys 42atomys approved these changes

Assignees

@rgaiffe rgaiffe

Labels
sponsor 💖 This is created be a sponsor of project
Projects
None yet
Milestone
3.0 Beta Release 👷
Development

Successfully merging this pull request may close these issues.

feat: Create monitoring Prometheus with operator
2 participants
@rgaiffe @42atomys