Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow construction of postgres request like formatting module #106

Closed
1 task done
42atomys opened this issue Oct 7, 2022 · 0 comments · Fixed by #145
Closed
1 task done

feat: allow construction of postgres request like formatting module #106

42atomys opened this issue Oct 7, 2022 · 0 comments · Fixed by #145
Labels
domain/complicated 🟨 The relationship between cause and effect requires analysis or expertise type/feature ⭐ Addition of new feature type/improvement ✨ Improvement to an existing feature
Milestone
1.0

Comments

@42atomys
Copy link
Owner

42atomys commented Oct 7, 2022

Is your feature request related to a problem? Please describe

Actually the postgres configuration has really basic and dont allow us to do anything.

  # In which table do you want to store the data
  tableName: 'webhooks_deliveries'
  # In which column do you want to store the data (data is sent in string format on this field)
  dataField: 'raw_data'

the reflected code behind is

request := fmt.Sprintf("INSERT INTO %s(%s) VALUES ($1)", c.config.TableName, c.config.DataField)

We cant perform an update, a delete, base the updated value or inserted value on some part of the payload.

Describe the solution you'd like

To be able to use the same formating module in storages like redis and postgres to allow to do all actions according to the specs provided in the configuration

Describe alternatives you've considered

No response

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@42atomys 42atomys added type/feature ⭐ Addition of new feature type/improvement ✨ Improvement to an existing feature labels Oct 7, 2022
@github-actions github-actions bot added the state/triage 🚦 Has not been triaged & therefore, not ready for work label Oct 7, 2022
@42atomys 42atomys added state/confirmed 💜 domain/complicated 🟨 The relationship between cause and effect requires analysis or expertise and removed state/triage 🚦 Has not been triaged & therefore, not ready for work labels Oct 7, 2022
@42atomys 42atomys added this to Future Nov 14, 2022
@42atomys 42atomys moved this to To do in Future Nov 14, 2022
@42atomys 42atomys added this to the 1.0 milestone Nov 14, 2022
@42atomys 42atomys mentioned this issue Jun 30, 2023
Merged
4 tasks
42atomys added a commit that referenced this issue Jun 30, 2023
@42atomys
feat: formatting feature for postgresql query (#145)
e2cbb72 
**Relative Issues:** Resolve #106 

**Describe the pull request**
This pull request introduces a new feature: a formatting function for
PostgreSQL queries. This feature is designed to improve the readability
and maintainability of SQL queries by automatically applying consistent
formatting rules. The objective of this feature is to help developers
write clearer, more understandable SQL queries, making the code easier
to read, understand, and debug. By introducing this formatting feature,
we aim to enhance developer productivity and the overall quality of our
codebase.

**Checklist**

- [ ] I have linked the relative issue to this pull request
- [ ] I have made the modifications or added tests related to my PR
- [ ] I have added/updated the documentation for my RP
- [ ] I put my PR in Ready for Review only when all the checklist is
checked
@github-project-automation github-project-automation bot moved this from To do to Done in Future Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
domain/complicated 🟨 The relationship between cause and effect requires analysis or expertise type/feature ⭐ Addition of new feature type/improvement ✨ Improvement to an existing feature
Projects
Future
Status: Done
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

feat: formatting feature for postgresql query 42atomys/webhooked
1 participant
@42atomys