chore: use koanf instead of viper to allow more possibility on configuration #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #160 +/- ##
==========================================
- Coverage 94.49% 94.11% -0.39%
==========================================
Files 22 22
Lines 1363 1393 +30
==========================================
+ Hits 1288 1311 +23
- Misses 51 56 +5
- Partials 24 26 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
This pull request involves switching from the Viper library to the Koanf library in a Go application. The primary motivation behind this change is to enhance the application's configuration possibilities. Viper, although a comprehensive solution for configuration in Go applications, has some limitations, particularly its case-insensitive behavior and a large number of hardcoded dependencies, which result in a bigger binary size compared to Koanf. For instance, a simple program using Viper is significantly larger (about 313%) than its Koanf equivalent
Checklist
Additional context
This switch to Koanf aims to reduce the application's binary size and dependency footprint while maintaining or enhancing configuration capabilities. The choice between Viper and Koanf largely depends on the specific needs and constraints of the application in question.