Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(logging): Add prometheus metrics & structure logs #45

Merged
merged 19 commits into from
Mar 13, 2022
Merged

feat(logging): Add prometheus metrics & structure logs #45

merged 19 commits into from
Mar 13, 2022

Conversation

42atomys
Copy link
Owner

@42atomys 42atomys commented Mar 12, 2022 •
edited
Loading

Relative Issues: Resolve #42

Describe the pull request

Add a prometheus endpoint to provide metrics about application and structure the logs given by the application

TODO

  • Add prometheus /metrics endpoint
  • Add possibility to enable/disable the prometheus endpoint via configuration
  • Add a logging middleware to provide more logs when application is running

Checklist

  • I have linked the relative issue to this pull request
  • I have made the modifications or added tests related to my PR
  • I have added/updated the documentation for my RP
  • I put my PR in Ready for Review only when all the checklist is checked

Breaking changes ?
no

Additional context
Documentation here : https://github.com/42Atomys/webhooked/wiki/Observability

@42atomys 42atomys added aspect/dex 🤖 Concerns developers' experience with the codebase priority/low 🟩 Priority 4 - Low priority and doesn't need to be rushed domain/obvious 🟩 Represents the "known knowns" issue. It's Obviously labels Mar 12, 2022
@42atomys 42atomys self-assigned this Mar 12, 2022
@42atomys 42atomys added this to the 1.0 milestone Mar 12, 2022
42atomys added 13 commits March 12, 2022 18:41
@42atomys
feat(observability): Allow user to toggle /metrics endpoint and prome…
213170b 
…theus strategy (disable by default)
@42atomys
chore(github/actions): Use tests config file instead of example
9b35cb2
@42atomys
feat(observability): Structure middlewares and tests
0c1e1ba
@42atomys
chore(configuration): Move log in right place
81bcfd2
@42atomys
chore(logging): Add more debug logs
233e714
@42atomys
Merge branch 'main' into 42Atomys/issue42
1dcb2cd
@42atomys
chore(configuration): Rework error messages on storage
b2311a3
@42atomys
chore(configuration): Rework error messages on configuration validation
4b4421d
@42atomys
chore(configuration): Rework error messages on security load
1ef1b9a
@42atomys
chore(server): Rework debug logs on handlers
862ffa1
@42atomys
docs(server): Write documentation for server v1alpha1
ddf5ead
@42atomys
docs(storage): Rewrite documentation of storages
566cb8f
@42atomys
docs(storage): Fix misspell on documentation
b98a89f
@42atomys 42atomys marked this pull request as ready for review March 13, 2022 00:50
@42atomys 42atomys requested a review from rgaiffe as a code owner March 13, 2022 00:50
@42atomys
Copy link
Owner Author

@rgaiffe takes a look 👀

@42atomys 42atomys merged commit e01f2c8 into main Mar 13, 2022
@42atomys 42atomys deleted the 42Atomys/issue42 branch March 13, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgaiffe rgaiffe Awaiting requested review from rgaiffe rgaiffe is a code owner

Assignees

@42atomys 42atomys

Labels
aspect/dex 🤖 Concerns developers' experience with the codebase domain/obvious 🟩 Represents the "known knowns" issue. It's Obviously priority/low 🟩 Priority 4 - Low priority and doesn't need to be rushed
Projects
Stud42 V3
Archived in project
Milestone
1.0
Development

Successfully merging this pull request may close these issues.

feat: Prometheus /metrics data exportation
1 participant
@42atomys