Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(storage): remove gob encoding on rabbitmq #86

Merged
merged 1 commit into from
Jun 12, 2022
Merged

chore(storage): remove gob encoding on rabbitmq #86

merged 1 commit into from
Jun 12, 2022

Conversation

42atomys
Copy link
Owner

@42atomys 42atomys commented Jun 12, 2022 •
edited
Loading

Describe the pull request

Encoding as gob is not necessary and can cause invalid json payload in rare case

Checklist

  • I have linked the relative issue to this pull request
  • I have made the modifications or added tests related to my PR
  • I have added/updated the documentation for my RP
  • I put my PR in Ready for Review only when all the checklist is checked

Breaking changes ?
yes/no

Additional context

@42atomys 42atomys requested a review from rgaiffe as a code owner June 12, 2022 21:55
@42atomys 42atomys merged commit 05f1138 into main Jun 12, 2022
@42atomys 42atomys deleted the chore/remove-unused-gob branch June 12, 2022 21:55
42atomys added a commit that referenced this pull request Jun 12, 2022
@42atomys
chore(storage): remove gob encoding on rabbitmq (#86)
dbf27d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgaiffe rgaiffe Awaiting requested review from rgaiffe rgaiffe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@42atomys