Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rabbitmq will reconnect if the channel is closed #99

Conversation

42atomys
Copy link
Owner

Relative Issues: Resolve #98

Describe the pull request

When the rabbitmq channel is closed, the storage actually never reconnect

Checklist

  • I have linked the relative issue to this pull request
  • I have made the modifications or added tests related to my PR
  • I have added/updated the documentation for my RP
  • I put my PR in Ready for Review only when all the checklist is checked

Breaking changes ?
no

Additional context

@42atomys 42atomys linked an issue Sep 10, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Sep 10, 2022

Codecov Report

Merging #99 (7460ffb) into main (c79f50f) will decrease coverage by 0.30%.
The diff coverage is 82.60%.

@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
- Coverage   94.25%   93.94%   -0.31%     
==========================================
  Files          22       22              
  Lines        1009     1040      +31     
==========================================
+ Hits          951      977      +26     
- Misses         39       44       +5     
  Partials       19       19              
Impacted Files Coverage Δ
pkg/storage/rabbitmq/rabbitmq.go 82.05% <82.60%> (+1.20%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@42atomys 42atomys marked this pull request as ready for review September 10, 2022 12:26
@42atomys 42atomys requested a review from rgaiffe as a code owner September 10, 2022 12:26
@42atomys 42atomys merged commit 4302881 into main Sep 10, 2022
@42atomys 42atomys deleted the 98-fix-rabbitmq-connection-dont-reconnect-if-the-channel-is-closed branch September 10, 2022 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: rabbitmq connection dont reconnect if the channel is closed
1 participant