MSTeams threading

[matthieu-foucault]

Would love to get some early feedback on this.

TODO:

• Polling for replies is a bit slow, I'm wondering if there is some info somewhere as to whether a message has replies
• Add some documentation indicating that PreserveThreading is now an option for MSteams.

[codeclimate]

Code Climate has analyzed commit 89f3abe and detected 0 issues on this pull request.

View more on Code Climate.

[matthieu-foucault]

Just starting to discover Go, so this might not be the way to do this

[42wim]

Thanks for taking a look at this! 👍

Polling for replies is a bit slow, I'm wondering if there is some info somewhere as to whether a message has replies

Yes, that's why I didn't include it in my PR because with thousands of messages this becomes very very slow.

According to the most recent graph changelog: https://docs.microsoft.com/en-us/graph/changelog#teamwork they've fixed my issue https://github.com/microsoftgraph/microsoft-graph-docs-contrib/issues/6097 wrt to lastModifiedDateTime

Changed lastModifiedDateTime property in the chatMessage resource to represent the time the entity was last touched. It will always be set and never have a null value

So for the replies you can now keep state and see if this property has changed, if so there's a new reply.

[matthieu-foucault]

@42wim thanks for the tip, I'll look into using lastModifiedDateTime at some point this week

[matthieu-foucault]

@42wim sounds like the Delta query would be very useful, but that doesn't seem to be available in the library we're using. Sounds like the code generator there needs to be fixed too (yaegashi/msgraph.go#22). Any suggestion for the best way to move forward?

[42wim]

Well, I've also looked into delta when implementing support for msteams. (I've added the methods myself then)
Delta didn't work, see https://github.com/microsoftgraph/microsoft-graph-docs-contrib/issues/6235 and #967

So I'd go with my previous suggestion (or you can try to add delta in a forked library, maybe it's fixed)

[DAcodedBEAT]

Just pulled this code down and set the PreserveThreading config and it looks like it worked for me!