Handle Whatsapp threading/replies

[yousefmansy1]

Handle Whatsapp threading/replies, based on commit 6afa93e from #1934
In this change we are updating whatsapp message IDs to include sender JID as this is necessary to reply to a message

• Response to specific message tulir/whatsmeow#88 (comment)
• Quoting messages for reply in a group causes issues for IOS users tulir/whatsmeow#148 (comment)

[yousefmansy1]

Finally figured out the issue.
I was 90% of the way there, you actually also need to add a QuotedMessage to the context info.

Only figured it out by taking a look at the mautrix-whatsapp repo and tracing through what they're doing.
https://github.com/mautrix/whatsapp/blob/e0a9b0e8bb25b70196b78079dca2eeef35d526b6/portal.go#L3719-L3726

Granted the issues I linked actually mentioned this upon looking at it again.
However, they called it out as optional, idk lol.

[codeclimate]

Code Climate has analyzed commit 264ab84 and detected 7 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	1
Duplication	6

View more on Code Climate.

[yousefmansy1]

Replies should work across the board now.
@qaisjp do you think you can take a look?

Or perhaps @ilmaisin since you've made some commits to the whatsappmulti bridge.

(will post screenshots later its late I'm tired lol)

[ilmaisin]

Replies should work across the board now. @qaisjp do you think you can take a look?

Or perhaps @ilmaisin since you've made some commits to the whatsappmulti bridge.

(will post screenshots later its late I'm tired lol)

Should your PR now work in both directions? I can probaly try it this weekend. I have my draft PR running in my instance, but it is rx-only.

[yousefmansy1]

Should your PR now work in both directions? I can probaly try it this weekend. I have my draft PR running in my instance, but it is rx-only.

Yes it works in both directions. 👍

[ilmaisin]

If a Telegram user replies to a message orignating in Whatsapp, the reply that is sent back to Whatsapp includes both the "proper" quote as well as a textual quote. This may be a matter of another PR, though.

[yousefmansy1]

If a Telegram user replies to a message orignating in Whatsapp, the reply that is sent back to Whatsapp includes both the "proper" quote as well as a textual quote. This may be a matter of another PR, though.

I believe this might be unavoidable, as then you have QuoteDisable=false it will append reply information directly into the message text.
The receiving bridges will simply relay whatever is in the message.Text body.

matterbridge/bridge/telegram/handlers.go

Lines 113 to 119 in 24f6747

	if !b.GetBool("QuoteDisable") {
	quote := message.ReplyToMessage.Text
	if quote == "" {
	quote = message.ReplyToMessage.Caption
	}
	rmsg.Text = b.handleQuote(rmsg.Text, usernameReply, quote)
	}

This would require some more significant rework of how replies work to resolve.

For now you'll just have to use QuoteDisable=true

[42wim]

Great job @yousefmansy1 !