Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slack: topics can contain newlines #163

Closed
Peter4825 opened this issue Mar 27, 2018 · 1 comment
Closed

slack: topics can contain newlines #163

Peter4825 opened this issue Mar 27, 2018 · 1 comment

Comments

@Peter4825
Copy link
Contributor

In slack, /topic's for channels can contain newlines. This translates very badly to irc, at the moment, matterircd is sending garbage to the client, as newlines are not allowed at all, nor are carriage returns.
@Peter4825
Copy link
Contributor Author

While newlines are now properly filtered out, carriage return characters are not.

The newlines in the slack topics are \n\r, and it is also not valid for IRC to have \r characters in a message, so it can also not be in the topic...

42wim added a commit to 42wim/mm-go-irckit that referenced this issue Apr 5, 2018
@42wim
Fix carriage return in topic to client. Closes 42wim/matterircd#163
9212077
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Peter4825