Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show scrollback in same channel/query window #393

Merged
merged 3 commits into from
Feb 20, 2021

Conversation

hloeung
Copy link
Collaborator

@hloeung hloeung commented Feb 12, 2021

Rather than show as being from the "mattermost" user or in the "mattermost" query window, this shows scrollback text in the same window as the one we're requesting scrollback for. Fixes #391

@hloeung hloeung marked this pull request as draft February 12, 2021 08:38
@hloeung hloeung changed the title Show scrollback in same channel/query window WIP: Show scrollback in same channel/query window Feb 12, 2021
@hloeung
Copy link
Collaborator Author

hloeung commented Feb 12, 2021

It works for channel, but I can't seem to get it to work for DMs. I think I need to use u.MsgSpoofUser with the receiver / sender thingy like in mm-go-irckit/userbridge.go:

    if event.Sender.Me {
            if event.Receiver.Me {
                    u.MsgSpoofUser(u, u.Nick, event.Text)
            } else {
                    u.MsgSpoofUser(u, event.Receiver.Nick, event.Text)
            }

@42wim, what do you think?

@hloeung hloeung force-pushed the scrollback-same-channel-query branch from 0418f15 to f389ec5 Compare February 13, 2021 07:35
@hloeung hloeung marked this pull request as ready for review February 13, 2021 07:42
@hloeung hloeung changed the title WIP: Show scrollback in same channel/query window Show scrollback in same channel/query window Feb 13, 2021
@hloeung
Copy link
Collaborator Author

hloeung commented Feb 13, 2021

Okay, got something that works for both channel and DM/query.

@hloeung hloeung force-pushed the scrollback-same-channel-query branch from 953f733 to 666b132 Compare February 13, 2021 07:47
@42wim 42wim added this to the 0.24.0 milestone Feb 13, 2021
@hloeung hloeung force-pushed the scrollback-same-channel-query branch from 666b132 to 87694fa Compare February 13, 2021 20:41
@hloeung hloeung force-pushed the scrollback-same-channel-query branch 2 times, most recently from 54a15c9 to 0954f18 Compare February 13, 2021 20:45
@hloeung hloeung changed the title Show scrollback in same channel/query window Show scrollback in same channel/query window. Fixes #391 Feb 14, 2021
@hloeung hloeung changed the title Show scrollback in same channel/query window. Fixes #391 Show scrollback in same channel/query window Feb 14, 2021
@42wim 42wim merged commit 951c3f6 into 42wim:master Feb 20, 2021
@42wim
Copy link
Owner

42wim commented Feb 20, 2021

very nice 👍

@hloeung hloeung deleted the scrollback-same-channel-query branch February 20, 2021 23:49
@42wim 42wim modified the milestones: 0.24.0, 0.23.1 Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scrollback appears in chat with mattermost user, not in actual channels or DMs
2 participants