-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show scrollback in same channel/query window #393
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hloeung
changed the title
Show scrollback in same channel/query window
WIP: Show scrollback in same channel/query window
Feb 12, 2021
It works for channel, but I can't seem to get it to work for DMs. I think I need to use u.MsgSpoofUser with the receiver / sender thingy like in mm-go-irckit/userbridge.go:
@42wim, what do you think? |
hloeung
force-pushed
the
scrollback-same-channel-query
branch
from
February 13, 2021 07:35
0418f15
to
f389ec5
Compare
hloeung
changed the title
WIP: Show scrollback in same channel/query window
Show scrollback in same channel/query window
Feb 13, 2021
Okay, got something that works for both channel and DM/query. |
hloeung
force-pushed
the
scrollback-same-channel-query
branch
from
February 13, 2021 07:47
953f733
to
666b132
Compare
hloeung
force-pushed
the
scrollback-same-channel-query
branch
from
February 13, 2021 20:41
666b132
to
87694fa
Compare
hloeung
force-pushed
the
scrollback-same-channel-query
branch
2 times, most recently
from
February 13, 2021 20:45
54a15c9
to
0954f18
Compare
hloeung
changed the title
Show scrollback in same channel/query window
Show scrollback in same channel/query window. Fixes #391
Feb 14, 2021
hloeung
changed the title
Show scrollback in same channel/query window. Fixes #391
Show scrollback in same channel/query window
Feb 14, 2021
very nice 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than show as being from the "mattermost" user or in the "mattermost" query window, this shows scrollback text in the same window as the one we're requesting scrollback for. Fixes #391