Set correct IRC PRIVMSG nick when receiving direct messages #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the code creates the following IRC raw message (direct message sent from "buddy", to "me"): :buddy!buddy@https://chat.example.com PRIVMSG buddy :hi However, according to the IRC spec rfc1459 4.4.1 (https://tools.ietf.org/html/rfc1459), direct messages should have my username set as the receiver. i.e. :buddy!buddy@https://chat.example.com PRIVMSG me :hi Fixes: 42wim#406
|
I've just tested that, and it is working fine - it seems to fix an old issue with ZNC I'm facing (see issue #296 ). |
|
Thank you so much for the patch, @the-real-ed! |
|
Thank you for this fix @the-real-ed and the rest for testing :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the code creates the following IRC raw message (direct message sent from "buddy", to "me"):
However, according to the IRC spec rfc1459 4.4.1 (https://tools.ietf.org/html/rfc1459), direct messages should have my username set as the receiver.
i.e.
Fixes: #406
This code has been tested and confirmed to be working on v0.23
Thanks to @hloeung for helping verify the patch works.