Save last viewed at state on logout and only use stored last viewed at if newer than what the server knows #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hloeung
force-pushed
the
persistent-last-viewed
branch
from
acc6713 to
ee6a30c
Compare
42wim
reviewed
Apr 2, 2021
…t if newer than what the server knows
hloeung
force-pushed
the
persistent-last-viewed
branch
from
f80f321 to
3a0d0b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful for when you want to restart matterircd and not have any logs replayed. To flush or force saving of last viewed at state, use the
logoutcommand per below:We also want to make sure we use the server's known channel last viewed if it's newer than what's saved to further reduce messages we've
seen.