Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return ERR_NOTREGISTERED when trying to join before registration #434

Merged
merged 1 commit into from
May 21, 2021

Conversation

Peter4825
Copy link
Contributor

Newer versions of the IRC protocol support a message called CAP to negotiate capabilities, what the server can and cannot do

In order to implement this properly, the newest version of irssi (currently unreleased) sends out a JOIN command in order to see if the server has properly replied to the CAP message or not.

Since matterircd is the only ircd not responding with an error to this join message, irssi cannot connect to matterircd anymore. Instead the connection times out.

This patch fixes this by ensuring the join message returns an error if tried before the registration is complete

@42wim 42wim added this to the 0.24.2 milestone May 21, 2021
@42wim 42wim merged commit bd7eba7 into 42wim:master May 21, 2021
@42wim
Copy link
Owner

42wim commented May 21, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants